Ubuntu
qtmultimedia-opensource-src package

Merge lp://qastaging/~phablet-team/ubuntu/utopic/qtmultimedia-opensource-src/use-camerabin1 into lp://qastaging/ubuntu/utopic/qtmultimedia-opensource-src

  1. Utopic (14.10)
  2. use-camerabin1
  3. Merge into utopic
Proposed by Ugo Riboni
Status: Needs review
Proposed branch: lp://qastaging/~phablet-team/ubuntu/utopic/qtmultimedia-opensource-src/use-camerabin1
Merge into: lp://qastaging/ubuntu/utopic/qtmultimedia-opensource-src
Diff against target: 444 lines (+424/-0)
3 files modified
debian/changelog (+6/-0)
debian/patches/series (+1/-0)
debian/patches/use-camerabin1.diff (+417/-0)
To merge this branch: bzr merge lp://qastaging/~phablet-team/ubuntu/utopic/qtmultimedia-opensource-src/use-camerabin1
Reviewer Review Type Date Requested Status
Iain Lane Needs Fixing
Jim Hodapp (community) code Approve
Dmitry Shachnev Needs Information
Review via email: mp+221223@code.qastaging.launchpad.net

Commit message

Use camerabin1 instead of camerabin2 to improve the ability to query and change resolution and framerate, as well as have less crashes and lock ups when recording video.

Description of the change

Use camerabin1 instead of camerabin2 to improve the ability to query and change resolution and framerate, as well as have less crashes and lock ups when recording video.

Audio settings are not currently honoured, due to porting that part to camerabin1 proving trickier than the rest.

To post a comment you must log in.
Revision history for this message
Jim Hodapp (jhodapp) wrote :

A few comments inline. Once these get resolved, it should be ready.

Reply
Revision history for this message
Dmitry Shachnev (mitya57) wrote :

Where does this patch originate from? Did you forward it upstream?

(Hint: DEP-3 patch headers sometimes help.)

review: Needs Information
Reply
lp://qastaging/~phablet-team/ubuntu/utopic/qtmultimedia-opensource-src/use-camerabin1 updated
21. By Ugo Riboni

Fix some style issues and properly respect the audio settings

Revision history for this message
Ugo Riboni (uriboni) wrote :

Fixed your concerns (those I haven't have a comment in line explaining why).
Also added some code in the constructor of the CamerabinSession to setup the audio pipeline properly so that it will respect the audio settings passed in by the user.

Reply
Revision history for this message
Jim Hodapp (jhodapp) wrote :

Looks good, thanks!

review: Approve (code)
Reply
Revision history for this message
Iain Lane (laney) wrote :

Would you please forward this upstream and then link to the bug in the patch header? It'd be good to have some upstream review.

review: Needs Fixing
Reply

Unmerged revisions

21. By Ugo Riboni

Fix some style issues and properly respect the audio settings

20. By Ugo Riboni

Use camerabin1 instead of camerabin2 to improve success in querying and setting resolution and framerate

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches