Merge lp://qastaging/~philip.scott/pantheon-notes/open-with into lp://qastaging/pantheon-notes

Proposed by Felipe Escoto
Status: Needs review
Proposed branch: lp://qastaging/~philip.scott/pantheon-notes/open-with
Merge into: lp://qastaging/pantheon-notes
Diff against target: 525 lines (+209/-85)
8 files modified
CMakeLists.txt (+0/-1)
data/pantheon-notes.desktop (+2/-1)
src/Application.vala (+61/-6)
src/Main.vala (+0/-17)
src/Services/Page.vala (+19/-5)
src/Widgets/Editor.vala (+14/-11)
src/Widgets/PagesList.vala (+18/-4)
src/Widgets/Window.vala (+95/-40)
To merge this branch: bzr merge lp://qastaging/~philip.scott/pantheon-notes/open-with
Reviewer Review Type Date Requested Status
Zisu Andrei (community) Needs Fixing
Review via email: mp+289845@code.qastaging.launchpad.net

Commit message

open-with support

To post a comment you must log in.
Revision history for this message
Zisu Andrei (matzipan) wrote :

Some feedback. I can't see anything obviously wrong. Haven't build it.

Revision history for this message
Zisu Andrei (matzipan) wrote :

Built it and ran it, and I couldn't find any "Open with" menu entry.

review: Needs Fixing

Unmerged revisions

10. By Felipe Escoto

Open-with support

9. By Felipe Escoto

working with CMD args

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: