Merge lp://qastaging/~philip.scott/pantheon-photos/dark-app into lp://qastaging/~pantheon-photos/pantheon-photos/trunk
Proposed by
Felipe Escoto
| Status: | Rejected |
|---|---|
| Rejected by: | Danielle Foré |
| Proposed branch: | lp://qastaging/~philip.scott/pantheon-photos/dark-app |
| Merge into: | lp://qastaging/~pantheon-photos/pantheon-photos/trunk |
| Diff against target: |
201 lines (+22/-21) 5 files modified
src/Application.vala (+1/-1) src/CollectionPage.vala (+2/-2) src/PhotoPage.vala (+14/-14) src/library/LibraryWindow.vala (+3/-2) src/sidebar/Rating.vala (+2/-2) |
| To merge this branch: | bzr merge lp://qastaging/~philip.scott/pantheon-photos/dark-app |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Danielle Foré | Disapprove | ||
|
Review via email:
|
|||
Commit message
Use dark theme for the main Photos app
Description of the change
Dark app?
To post a comment you must log in.
Revision history for this message
| Danielle Foré (danrabbit) wrote | # |
Unmerged revisions
- 2981. By Felipe Escoto
-
Dark app MVP
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
I think this needs to be put on hold because we have some unsolved issues, specifically certain icons not using the symbolic variant or being otherwise unlegible on a dark background. We haven't done any testing here at all. So I would say hold until Loki +1 and then we don't have to worry about breaking things as much since we'll have time to fix them