Photos

Merge lp://qastaging/~philip.scott/pantheon-photos/editable-title into lp://qastaging/~pantheon-photos/pantheon-photos/trunk

  1. editable-title
  2. Merge into trunk
Proposed by Felipe Escoto
Status: Merged
Approved by: Danielle Foré
Approved revision: 3037
Merged at revision: 3038
Proposed branch: lp://qastaging/~philip.scott/pantheon-photos/editable-title
Merge into: lp://qastaging/~pantheon-photos/pantheon-photos/trunk
Diff against target: 184 lines (+131/-5)
3 files modified
src/CMakeLists.txt (+2/-1)
src/sidebar/EditableTitle.vala (+125/-0)
src/sidebar/metadata/LibraryProperties.vala (+4/-4)
To merge this branch: bzr merge lp://qastaging/~philip.scott/pantheon-photos/editable-title
Reviewer Review Type Date Requested Status
Danielle Foré Approve
Review via email: mp+310114@code.qastaging.launchpad.net

Commit message

LibraryProperties: Change title entry for an EditableTitle

To post a comment you must log in.
Revision history for this message
Danielle Foré (danrabbit) wrote :

I would like to have:
* The whole label be activatable
* save on focus out

I think without those it feels a little awkward

review: Needs Fixing
Revision history for this message
Felipe Escoto (philip.scott) wrote :

I kinda disagree on the save on focus out. I feel like having that confirmation is good either with clicking the button, or by pressing enter

But it does feel a lot less awkward with the whole label being clickable

lp://qastaging/~philip.scott/pantheon-photos/editable-title updated
3035. By Felipe Escoto

Editable label on Library Details

Revision history for this message
Danielle Foré (danrabbit) wrote :

It appears that clicking the icon focuses the entry automatically, but clicking the label does not

lp://qastaging/~philip.scott/pantheon-photos/editable-title updated
3036. By Felipe Escoto

Grab focus and refactoring

Revision history for this message
Danielle Foré (danrabbit) wrote :

I think you might have made a small oops :p

Revision history for this message
Danielle Foré (danrabbit) :
lp://qastaging/~philip.scott/pantheon-photos/editable-title updated
3037. By Felipe Escoto

Fixed my oops

Revision history for this message
Felipe Escoto (philip.scott) :
Revision history for this message
Danielle Foré (danrabbit) wrote :

LGTM. I'm happy

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: