Photos

Merge lp://qastaging/~philip.scott/pantheon-photos/split-tools into lp://qastaging/~pantheon-photos/pantheon-photos/trunk

  1. split-tools
  2. Merge into trunk
Proposed by Felipe Escoto
Status: Merged
Approved by: Danielle Foré
Approved revision: 3015
Merged at revision: 3015
Proposed branch: lp://qastaging/~philip.scott/pantheon-photos/split-tools
Merge into: lp://qastaging/~pantheon-photos/pantheon-photos/trunk
Diff against target: 4751 lines (+2389/-2328)
5 files modified
src/CMakeLists.txt (+3/-0)
src/editing_tools/AdjustTool.vala (+747/-0)
src/editing_tools/CropTool.vala (+1252/-0)
src/editing_tools/EditingTools.vala (+0/-2328)
src/editing_tools/RedEyeTool.vala (+387/-0)
To merge this branch: bzr merge lp://qastaging/~philip.scott/pantheon-photos/split-tools
Reviewer Review Type Date Requested Status
Danielle Foré Approve
Review via email: mp+306692@code.qastaging.launchpad.net

Commit message

Split editing tools into separate files

Description of the change

Because 3000 lines in a file is silly

To post a comment you must log in.
Revision history for this message
Danielle Foré (danrabbit) wrote :

We should probably preserve the Yorba copyright from the original file in the new copyright headers. So the new Copyright header should be like

/*
* Copyright (c) 2009-2013 Yorba Foundation
* 2016 elementary LLC.
*

Revision history for this message
Danielle Foré (danrabbit) wrote :

Still compiles and nothing crashes. Looks like a straight move :)

lp://qastaging/~philip.scott/pantheon-photos/split-tools updated
3015. By Felipe Escoto

Split editing tools into separate file

Revision history for this message
Danielle Foré (danrabbit) wrote :

lgtm!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: