Merge lp://qastaging/~phill-ridout/openlp/fixes-IV into lp://qastaging/openlp

Proposed by Phill
Status: Merged
Merged at revision: 2889
Proposed branch: lp://qastaging/~phill-ridout/openlp/fixes-IV
Merge into: lp://qastaging/openlp
Diff against target: 852 lines (+172/-161)
25 files modified
openlp/core/common/__init__.py (+16/-1)
openlp/core/common/actions.py (+1/-1)
openlp/core/common/i18n.py (+4/-14)
openlp/core/common/registry.py (+2/-23)
openlp/core/display/html/display.js (+29/-22)
openlp/core/display/render.py (+1/-1)
openlp/core/display/screens.py (+2/-10)
openlp/core/lib/theme.py (+1/-0)
openlp/core/state.py (+2/-11)
openlp/core/ui/advancedtab.py (+1/-1)
openlp/core/ui/icons.py (+4/-14)
openlp/plugins/bibles/lib/__init__.py (+23/-29)
openlp/plugins/bibles/lib/db.py (+22/-25)
openlp/plugins/bibles/lib/manager.py (+4/-2)
openlp/plugins/custom/forms/editcustomdialog.py (+2/-0)
openlp/plugins/songs/forms/editsongdialog.py (+2/-0)
openlp/plugins/songs/lib/db.py (+3/-1)
openlp/plugins/songs/lib/importers/cclifile.py (+2/-0)
openlp/plugins/songs/lib/importers/dreambeam.py (+2/-1)
openlp/plugins/songs/lib/importers/easyslides.py (+2/-0)
openlp/plugins/songs/lib/importers/easyworship.py (+1/-1)
openlp/plugins/songs/lib/importers/songbeamer.py (+1/-1)
tests/functional/openlp_core/common/test_common.py (+43/-1)
tests/functional/openlp_core/lib/test_theme.py (+1/-1)
tests/functional/openlp_core/ui/test_icons.py (+1/-1)
To merge this branch: bzr merge lp://qastaging/~phill-ridout/openlp/fixes-IV
Reviewer Review Type Date Requested Status
Tim Bentley Approve
Review via email: mp+371023@code.qastaging.launchpad.net

Commit message

Refactors and fixes

Description of the change

Refactor `singleton` classes to use a `singleton` metaclass
Fixes for a number of reported issues
Tidy ups, and improvements as suggested by pycharm

To post a comment you must log in.
Revision history for this message
Raoul Snyman (raoul-snyman) wrote :

Linux tests passed!

Revision history for this message
Raoul Snyman (raoul-snyman) wrote :

Linting passed!

Revision history for this message
Tim Bentley (trb143) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.