Merge lp://qastaging/~phill-ridout/openlp/ftw-json into lp://qastaging/openlp/ftw-data

Proposed by Phill
Status: Merged
Approved by: Raoul Snyman
Approved revision: 21
Merged at revision: 20
Proposed branch: lp://qastaging/~phill-ridout/openlp/ftw-json
Merge into: lp://qastaging/openlp/ftw-data
Diff against target: 434 lines (+412/-1)
3 files modified
download_3.0.json (+326/-0)
scripts/hashgen.py (+1/-1)
scripts/jsongen.py (+85/-0)
To merge this branch: bzr merge lp://qastaging/~phill-ridout/openlp/ftw-json
Reviewer Review Type Date Requested Status
Raoul Snyman Approve
Tomas Groth Approve
Review via email: mp+363049@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2019-02-11.

Commit message

Add a JSON formatted config file for easier parsing and associated script

To post a comment you must log in.
Revision history for this message
Raoul Snyman (raoul-snyman) wrote : Posted in a previous version of this proposal

Two things:

1. Please add a commit message or a description ^^

2. Your new JSON file is either "download_3.0.json" or "download_3.0.conf" depending on whether you look at the file name, or the constant on line 366 of the diff below. Please choose one.

review: Needs Fixing
Revision history for this message
Tomas Groth (tomasgroth) wrote : Posted in a previous version of this proposal

2 minor things.

review: Needs Fixing
Revision history for this message
Tomas Groth (tomasgroth) :
review: Approve
Revision history for this message
Raoul Snyman (raoul-snyman) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: