OpenLP

Merge lp://qastaging/~phill-ridout/openlp/import-depreciations into lp://qastaging/openlp

  1. import-depreciations
  2. Merge into trunk
Proposed by Phill
Status: Superseded
Proposed branch: lp://qastaging/~phill-ridout/openlp/import-depreciations
Merge into: lp://qastaging/openlp
Diff against target: 346 lines (+118/-64)
10 files modified
openlp/core/common/__init__.py (+34/-1)
openlp/core/lib/pluginmanager.py (+3/-28)
openlp/core/ui/media/mediacontroller.py (+5/-13)
openlp/plugins/presentations/lib/impresscontroller.py (+2/-1)
openlp/plugins/presentations/lib/pdfcontroller.py (+1/-1)
openlp/plugins/presentations/lib/powerpointcontroller.py (+1/-1)
openlp/plugins/presentations/lib/pptviewcontroller.py (+1/-1)
openlp/plugins/presentations/lib/presentationtab.py (+1/-1)
openlp/plugins/presentations/presentationplugin.py (+5/-14)
tests/functional/openlp_core_common/test_common.py (+65/-3)
To merge this branch: bzr merge lp://qastaging/~phill-ridout/openlp/import-depreciations
Reviewer Review Type Date Requested Status
Tim Bentley Needs Fixing
Review via email: mp+324024@code.qastaging.launchpad.net

This proposal has been superseded by a proposal from 2017-05-14.

Description of the change

Fix the depreciated code, and refactor it.

Add this to your merge proposal:
--------------------------------
lp:~phill-ridout/openlp/import-depreciations (revision 2736)
[SUCCESS] https://ci.openlp.io/job/Branch-01-Pull/2007/
[SUCCESS] https://ci.openlp.io/job/Branch-02-Functional-Tests/1917/
[SUCCESS] https://ci.openlp.io/job/Branch-03-Interface-Tests/1853/
[SUCCESS] https://ci.openlp.io/job/Branch-04a-Code_Analysis/1233/
[FAILURE] https://ci.openlp.io/job/Branch-04b-Test_Coverage/1092/
Stopping after failure

To post a comment you must log in.
Revision history for this message
Tim Bentley (trb143) wrote :

Looks good but has issues with trunk!

review: Needs Fixing
lp://qastaging/~phill-ridout/openlp/import-depreciations updated
2733. By Phill

Update and refactor dynamic import code

2734. By Phill

Reworked the extension_loader function

2735. By Phill

head

2736. By Phill

pep

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.