Merge lp://qastaging/~phill-ridout/openlp/media_ext_refactors into lp://qastaging/openlp

Proposed by Phill
Status: Superseded
Proposed branch: lp://qastaging/~phill-ridout/openlp/media_ext_refactors
Merge into: lp://qastaging/openlp
Diff against target: 471 lines (+46/-131)
12 files modified
openlp/core/common/json.py (+0/-1)
openlp/core/lib/mediamanageritem.py (+2/-2)
openlp/core/lib/serviceitem.py (+5/-3)
openlp/core/ui/media/mediacontroller.py (+3/-29)
openlp/core/ui/media/mediaplayer.py (+0/-9)
openlp/core/ui/media/vlcplayer.py (+10/-26)
openlp/core/ui/servicemanager.py (+17/-9)
openlp/core/ui/themeform.py (+2/-4)
openlp/plugins/media/lib/mediaitem.py (+6/-6)
tests/functional/openlp_core/common/test_path.py (+0/-1)
tests/functional/openlp_core/ui/media/test_mediacontroller.py (+0/-21)
tests/functional/openlp_core/ui/media/test_vlcplayer.py (+1/-20)
To merge this branch: bzr merge lp://qastaging/~phill-ridout/openlp/media_ext_refactors
Reviewer Review Type Date Requested Status
Tim Bentley Needs Fixing
Review via email: mp+368212@code.qastaging.launchpad.net

This proposal has been superseded by a proposal from 2019-06-01.

Commit message

refactor media extensions

To post a comment you must log in.
Revision history for this message
Raoul Snyman (raoul-snyman) wrote :

Linux tests passed!

Revision history for this message
Raoul Snyman (raoul-snyman) wrote :

Linting passed!

Revision history for this message
Raoul Snyman (raoul-snyman) wrote :

macOS tests passed!

Revision history for this message
Tim Bentley (trb143) wrote :

Minor improvement please

review: Needs Fixing
2880. By Phill

Add media extensions in the service manager

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.