Merge lp://qastaging/~piastucki/bzr-xmloutput/emit_authors into lp://qastaging/bzr-xmloutput

Proposed by Piotr Piastucki
Status: Merged
Merged at revision: 171
Proposed branch: lp://qastaging/~piastucki/bzr-xmloutput/emit_authors
Merge into: lp://qastaging/bzr-xmloutput
Diff against target: 76 lines (+20/-6)
2 files modified
logxml.py (+12/-5)
tests/test_log_xml.py (+8/-1)
To merge this branch: bzr merge lp://qastaging/~piastucki/bzr-xmloutput/emit_authors
Reviewer Review Type Date Requested Status
Guillermo Gonzalez Needs Fixing
Review via email: mp+161166@code.qastaging.launchpad.net

Description of the change

This is a fixed version of the changes proposed in lp:~amujumdar/bzr-xmloutput/emit_authors.

To post a comment you must log in.
Revision history for this message
Guillermo Gonzalez (verterok) wrote :

Hi Piotr,

Thanks for working on this. Looks like there is an identation issue at line 10 of the diff that trigger a lot of test failures:

FAILED (failures=27, errors=2)

I'll push it with the fixes.

Thanks.

review: Needs Fixing

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: