Merge lp://qastaging/~pirabarlen-cheenaramen/ubuntu/wily/nagios-plugins/crypto-fix into lp://qastaging/ubuntu/wily/nagios-plugins

Proposed by Pirabarlen Cheenaramen ( Selven )
Status: Needs review
Proposed branch: lp://qastaging/~pirabarlen-cheenaramen/ubuntu/wily/nagios-plugins/crypto-fix
Merge into: lp://qastaging/ubuntu/wily/nagios-plugins
Diff against target: 30 lines (+11/-0)
2 files modified
debian/changelog (+6/-0)
plugins/sslutils.c (+5/-0)
To merge this branch: bzr merge lp://qastaging/~pirabarlen-cheenaramen/ubuntu/wily/nagios-plugins/crypto-fix
Reviewer Review Type Date Requested Status
Marc Deslauriers Disapprove
Review via email: mp+292494@code.qastaging.launchpad.net

Description of the change

Backported from latest. Use SSLv3 only if the system was compiled with SSLv3 support

To post a comment you must log in.
58. By Pirabarlen Cheenaramen ( Selven )

Backported from latest, use SSLv3 only if the system was compiled with SSLv3

Revision history for this message
Marc Deslauriers (mdeslaur) wrote :

Thanks for the merge request, but I don't see why this is still necessary.

nagios-plugins in no longer in Ubuntu 16.04 LTS and later.

This merge proposal was made against Wily, but in Wily, SSLv3 is not autonegotiated in OpenSSL. The only way SSLv3 would be used is if someone specifically used check_http with -S 3 to force it. As such, I don't think it's even worth doing an SRU for this.

Thanks!

review: Disapprove

Unmerged revisions

58. By Pirabarlen Cheenaramen ( Selven )

Backported from latest, use SSLv3 only if the system was compiled with SSLv3

57. By Pirabarlen Cheenaramen ( Selven )

Backported from latest, use SSLv3 only if specified, SSLv3 has known weaknesses

56. By Pirabarlen Cheenaramen ( Selven )

Backported from Latest. Disable SSLv3 if OpenSSL hasn't been compiled with SSLv3 support

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches