Merge lp://qastaging/~pitti/notify-osd/link-gcc-4.5 into lp://qastaging/notify-osd/lucid

Proposed by Martin Pitt
Status: Merged
Approved by: Mirco Müller
Approved revision: 428
Merged at revision: 428
Proposed branch: lp://qastaging/~pitti/notify-osd/link-gcc-4.5
Merge into: lp://qastaging/notify-osd/lucid
Diff against target: 79 lines (+18/-3)
2 files modified
configure.in (+9/-3)
tests/Makefile.am (+9/-0)
To merge this branch: bzr merge lp://qastaging/~pitti/notify-osd/link-gcc-4.5
Reviewer Review Type Date Requested Status
Mirco Müller (community) Approve
Review via email: mp+45025@code.qastaging.launchpad.net

Description of the change

When building current trunk on natty, I get a lot of errors like

  CCLD notify-osd
/usr/bin/ld.bfd.real: notify_osd-bubble.o: undefined reference to symbol 'XDeleteProperty'
/usr/bin/ld.bfd.real: note: 'XDeleteProperty' is defined in DSO /usr/lib64/libX11.so.6 so try adding it to the linker command line
/usr/lib64/libX11.so.6: could not read symbols: Invalid operation

/usr/bin/ld.bfd.real: notify_osd-gaussian-blur.o: undefined reference to symbol 'pixman_image_composite'
/usr/bin/ld.bfd.real: note: 'pixman_image_composite' is defined in DSO /usr/lib64/libpixman-1.so.0 so try adding it to the linker command line
/usr/lib64/libpixman-1.so.0: could not read symbols: Invalid operation

  CCLD test-modules
/usr/bin/ld.bfd.real: test_modules-bubble.o: undefined reference to symbol 'XDeleteProperty'
/usr/bin/ld.bfd.real: note: 'XDeleteProperty' is defined in DSO /usr/lib64/libX11.so.6 so try adding it to the linker command line

gcc 4.5 with --as-needed has a stricter linking behaviour which requires explicit linking with all necessary libraries. Some programs use direct libX11 or libpixman functions, and thus need to link to them explicitly.

To post a comment you must log in.
Revision history for this message
Mirco Müller (macslow) wrote :

Approved. Thakns for the fix pitti!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: