Merge lp://qastaging/~pitti/notify-osd/wnck_shutdown-precise into lp://qastaging/~canonical-dx-team/notify-osd/precise

Proposed by Martin Pitt
Status: Merged
Merged at revision: 449
Proposed branch: lp://qastaging/~pitti/notify-osd/wnck_shutdown-precise
Merge into: lp://qastaging/~canonical-dx-team/notify-osd/precise
Diff against target: 39 lines (+12/-1)
2 files modified
configure.in (+5/-0)
src/dnd.c (+7/-1)
To merge this branch: bzr merge lp://qastaging/~pitti/notify-osd/wnck_shutdown-precise
Reviewer Review Type Date Requested Status
Canonical Desktop Experience Team Pending
Review via email: mp+91258@code.qastaging.launchpad.net

Description of the change

Use wnck_shutdown() if available.

dnd_has_one_fullscreen_window() initializes libwnck, which causes notify-osd to
unnecessarily wake up on each focus change and keyboard event, even if there
are no notification bubbles for a long time.

To fix this, check if libwnck has the new wnck_shutdown() function and use it
if available. This function is available in Ubuntu Precise's libwnck3 now, and
will soon go upstream as well (already talked to Vincent Untz).

Bug: https://bugzilla.gnome.org/show_bug.cgi?id=642692
Bug-Ubuntu: https://launchpad.net/bugs/915389

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches