Juju Charms Collection
rabbitmq-server package

Merge lp://qastaging/~pjdc/charms/trusty/rabbitmq-server/avoid-unresolvable-nodename-next-rebase into lp://qastaging/~openstack-charmers-archive/charms/trusty/rabbitmq-server/next

  1. Trusty Tahr (14.04)
  2. avoid-unresolvable-nodename-next-rebase
  3. Merge into next
Proposed by Paul Collins
Status: Superseded
Proposed branch: lp://qastaging/~pjdc/charms/trusty/rabbitmq-server/avoid-unresolvable-nodename-next-rebase
Merge into: lp://qastaging/~openstack-charmers-archive/charms/trusty/rabbitmq-server/next
Diff against target: 13 lines (+3/-0)
1 file modified
hooks/rabbitmq_server_relations.py (+3/-0)
To merge this branch: bzr merge lp://qastaging/~pjdc/charms/trusty/rabbitmq-server/avoid-unresolvable-nodename-next-rebase
Reviewer Review Type Date Requested Status
OpenStack Charmers Pending
Review via email: mp+267739@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2015-08-12.

This proposal has been superseded by a proposal from 2015-08-18.

Description of the change

In one of the Openstack clouds I work with, reverse DNS lookup of a unit's private IP yields a result of the form os-A-B-C-D.instance.openstack.internal. The rabbitmq-server charm snips off the first component and assumes, without checking, that this is a usable nodename. For a number of reasons, that is not the case in this deployment. This MP adds an assertion to check that the result of the reverse lookup resolves in the forward direction. If this fails, we fall back in the same manner as when no PTR record is present, which allows rabbitmq-server to deploy successfully in the cloud I am using.

[Resubmit with r106: "get_local_nodename: spell get_host_ip(nodename) correctly"]

To post a comment you must log in.
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_lint_check #7920 rabbitmq-server-next for pjdc mp267733
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/7920/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_unit_test #7338 rabbitmq-server-next for pjdc mp267733
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/7338/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_amulet_test #5761 rabbitmq-server-next for pjdc mp267733
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/5761/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #7921 rabbitmq-server-next for pjdc mp267739
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/7921/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #7339 rabbitmq-server-next for pjdc mp267739
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/7339/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #5762 rabbitmq-server-next for pjdc mp267739
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/12059688/
Build: http://10.245.162.77:8080/job/charm_amulet_test/5762/

Revision history for this message
Tom Haddon (mthaddon) wrote :

This looks like a transient test failure but I can't be sure. Can someone confirm?

Unmerged revisions

106. By Paul Collins

get_local_nodename: spell get_host_ip(nodename) correctly

105. By Paul Collins

get_local_nodename: ensure the resulting nodename itself resolves

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches