Ubuntu Calendar App

Merge lp://qastaging/~pkunal-parmar/ubuntu-calendar-app/Minor-Performance into lp://qastaging/ubuntu-calendar-app

Minor-Performance
Merge into trunk

Proposed by Kunal Parmar on 2014-10-23

Status:	Rejected
Rejected by:	Mihir Soni on 2014-11-06
Proposed branch:	lp://qastaging/~pkunal-parmar/ubuntu-calendar-app/Minor-Performance
Merge into:	lp://qastaging/ubuntu-calendar-app
Diff against target:	368 lines (+115/-95) 6 files modified DayView.qml (+1/-1) MonthComponent.qml (+15/-10) MonthComponentDateDelegate.qml (+14/-7) TimeLineBase.qml (+27/-3) TimeLineBaseComponent.qml (+57/-73) WeekView.qml (+1/-1)
To merge this branch:	bzr merge lp://qastaging/~pkunal-parmar/ubuntu-calendar-app/Minor-Performance
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Mihir Soni		2014-10-23	Disapprove on 2014-11-06
Kunal Parmar			Needs Fixing on 2014-11-06
Ubuntu Phone Apps Jenkins Bot	continuous-integration		Needs Fixing on 2014-11-05
Review via email: mp+239371@code.qastaging.launchpad.net

Commit message

Some more minor performance improvements

Description of the change

Some more minor performance improvements

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-10-23:

#

FAILED: Continuous integration, rev:527
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/967/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1215
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1215/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/525

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/967/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-10-23:

#

FAILED: Continuous integration, rev:528
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/968/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1216
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1216/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/526

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/968/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-10-23:

#

FAILED: Continuous integration, rev:529
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/969/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1217
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1217/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/527

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/969/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-10-23:

#

FAILED: Continuous integration, rev:530
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/970/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1219
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1219/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/528

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/970/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-10-23:

#

FAILED: Continuous integration, rev:531
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/971/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1220
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1220/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/529

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/971/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-10-23:

#

PASSED: Continuous integration, rev:532
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/972/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1221
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1221/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/530

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/972/rebuild

review: Approve (continuous-integration)

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-10-23:

#

PASSED: Continuous integration, rev:533
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/974/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1224
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1224/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/532

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/974/rebuild

review: Approve (continuous-integration)

Revision history for this message

Mihir Soni (mihirsoni) wrote on 2014-10-24:

#

We might have to put spinner in year view.
Otherwise it works great :)
Thank you.

review: Approve

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-10-24:

#

FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/ubuntu-calendar-app-autolanding/419/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1260
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1260/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-autolanding/239

review: Needs Fixing (continuous-integration)

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-10-24:

#

FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/ubuntu-calendar-app-autolanding/420/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1269
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1269/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-autolanding/240

review: Needs Fixing (continuous-integration)

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-10-29:

#

FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/ubuntu-calendar-app-autolanding/424/
Executed test runs:
FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1371/console
FAILURE: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-autolanding/244/console

review: Needs Fixing (continuous-integration)

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-10-30:

#

FAILED: Continuous integration, rev:534
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/992/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1388
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1388/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/550

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/992/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-10-30:

#

FAILED: Continuous integration, rev:535
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/994/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1393
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1393/artifact/work/output/*zip*/output.zip
    FAILURE: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/552/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/994/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-11-05:

#

FAILED: Continuous integration, rev:536
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1005/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1450
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1450/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/560

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1005/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-11-05:

#

PASSED: Continuous integration, rev:537
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1006/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1451
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1451/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/561

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1006/rebuild

review: Approve (continuous-integration)

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-11-05:

#

FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/ubuntu-calendar-app-autolanding/428/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1453
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1453/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-autolanding/248

review: Needs Fixing (continuous-integration)

lp://qastaging/~pkunal-parmar/ubuntu-calendar-app/Minor-Performance updated on 2014-11-06

536. By Kunal Parmar on 2014-11-06: merge from trunk
537. By Kunal Parmar on 2014-11-06: merge

Revision history for this message

Kunal Parmar (pkunal-parmar) wrote on 2014-11-06:

#

Somehow branch got diverged, I will create separate MR to resolve merge related issue

review: Needs Fixing

Revision history for this message

Mihir Soni (mihirsoni) wrote on 2014-11-06:

#

Rejecting MR , As kunal has pushed separate MR ,

review: Disapprove

Revision history for this message

Mihir Soni (mihirsoni) wrote on 2014-11-06:

#

Reference MP , https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/Minor-Performance/+merge/239371

Unmerged revisions

537. By Kunal Parmar on 2014-11-06: merge
536. By Kunal Parmar on 2014-11-06: merge from trunk
535. By Kunal Parmar on 2014-10-30: dummy
534. By Kunal Parmar on 2014-10-30: merge from trunk
533. By Kunal Parmar on 2014-10-23: dummy
532. By Kunal Parmar on 2014-10-23: error resolved
531. By Kunal Parmar on 2014-10-23: code revert
530. By Kunal Parmar on 2014-10-23: some issue resolved
529. By Kunal Parmar on 2014-10-23: calculation
528. By Kunal Parmar on 2014-10-23: Font size caching

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk

The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes:

Kunal Parmar

Samith

Ubuntu Calendar Developers

to status/vote changes:

Nohat Bughead