Ubuntu Calendar App

Merge lp://qastaging/~pkunal-parmar/ubuntu-calendar-app/TapToCreateEvent into lp://qastaging/ubuntu-calendar-app

TapToCreateEvent
Merge into trunk

Proposed by Kunal Parmar on 2015-03-25

Status:

Merged

Approved by:

Alan Pope 🍺🐧🐱 🦄 on 2015-05-18

Approved revision:

631

Merged at revision:

646

Proposed branch:

lp://qastaging/~pkunal-parmar/ubuntu-calendar-app/TapToCreateEvent

Merge into:

lp://qastaging/ubuntu-calendar-app

Diff against target:

164 lines (+47/-12)

6 files modified

NewEvent.qml (+6/-0)
TimeLineBase.qml (+15/-2)
TimeLineBaseComponent.qml (+7/-1)
WeekView.qml (+0/-7)
tests/autopilot/calendar_app/tests/test_monthview.py (+5/-0)
tests/autopilot/calendar_app/tests/test_weekview.py (+14/-2)

To merge this branch:

bzr merge lp://qastaging/~pkunal-parmar/ubuntu-calendar-app/TapToCreateEvent

Related bugs:

Bug #1378380: [Calendar]Should add event by tapping on screen in Day view	Medium	Fix Released
Bug #1451557: Open edit mode off event when created via long tap	Undecided	Fix Committed

Link a bug report

Reviewer	Review Type	Date Requested	Status
Ubuntu Phone Apps Jenkins Bot	continuous-integration		Approve on 2015-05-09
Nicholas Skaggs (community)			Needs Fixing on 2015-04-23
Alan Pope 🍺🐧🐱 🦄 (community)		2015-03-25	Needs Fixing on 2015-04-13
Review via email: mp+254175@code.qastaging.launchpad.net

Commit message

Resolves Bug #1378380
Add event on tap

Description of the change

Resolves Bug #1378380
Add event on tap

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2015-03-26:

FAILED: Continuous integration, rev:616
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1111/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2427
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2427/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/582
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-vivid-amd64-ci/108

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1111/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Alan Pope 🍺🐧🐱 🦄 (popey) wrote on 2015-03-26:

Tapping created an event at 21:26, I think it should create an event which locks to the nearest 30 minutes.

The event is created, and then two more button presses are required (tap event, tap edit) to edit the event to change the title from "Untitled". Would it make more sense to go directly to edit event when created?

Revision history for this message

Kunal Parmar (pkunal-parmar) wrote on 2015-03-28:

> Tapping created an event at 21:26, I think it should create an event which
> locks to the nearest 30 minutes.
>

As per current implementation we are truncating minutes and creating event for currently touched hour.
It should have created event rounding to hour, for your case it should have created event on 21:00 to 22:00

Can you confirm once more ?

> The event is created, and then two more button presses are required (tap
> event, tap edit) to edit the event to change the title from "Untitled". Would
> it make more sense to go directly to edit event when created?

This can be done

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2015-03-28:

FAILED: Continuous integration, rev:617
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1114/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2442
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2442/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/585
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-vivid-amd64-ci/111

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1114/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2015-03-28:

FAILED: Continuous integration, rev:618
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1116/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2444
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2444/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/587
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-vivid-amd64-ci/113

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1116/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Kunal Parmar (pkunal-parmar) wrote on 2015-04-05:

so issue with jenkins was, first day was not visible but AP was trying to click on first day, which it could not see and thus AP fails.

Now scrolling view to make first day visible.

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2015-04-05:

FAILED: Continuous integration, rev:619
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1129/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2499/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/600/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-calendar-app-vivid-amd64-ci/126/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1129/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2015-04-05:

PASSED: Continuous integration, rev:621
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1132/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2503
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2503/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/603
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-vivid-amd64-ci/129

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1132/rebuild

review: Approve (continuous-integration)

Revision history for this message

Alan Pope 🍺🐧🐱 🦄 (popey) wrote on 2015-04-09:

Tested and this is great, thanks!

review: Approve

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2015-04-12:

FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/ubuntu-calendar-app-autolanding/489/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2583
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2583/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-autolanding/274
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-vivid-amd64-autolanding/61

review: Needs Fixing (continuous-integration)

Revision history for this message

Alan Pope 🍺🐧🐱 🦄 (popey) wrote on 2015-04-13:

testtools.matchers._impl.MismatchError: !=:
reference = datetime.datetime(2015, 4, 12, 22, 0)
actual = datetime.datetime(2015, 4, 12, 21, 30)

So we create an event on the half hour but the test always assumes it's on the hour, so that needs fixing.

review: Needs Fixing

Revision history for this message

Kunal Parmar (pkunal-parmar) wrote on 2015-04-13:

Sure, I'll fix this and other ap fail with week number Mr.

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2015-04-16:

FAILED: Continuous integration, rev:622
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1146/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2616
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2616/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/617
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-vivid-amd64-ci/143

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1146/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Kunal Parmar (pkunal-parmar) wrote on 2015-04-19:

From Video, test case seems to be running fine. There seems some issue with Jenkins server. Seems like python is getting some wrong date.

like in below log,
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/calendar_app/tests/test_monthview.py", line 142, in test_today_button
    self._go_to_today(1)
  File "/usr/lib/python3/dist-packages/calendar_app/tests/test_monthview.py", line 87, in _go_to_today
    self._assert_today()
  File "/usr/lib/python3/dist-packages/calendar_app/tests/test_monthview.py", line 74, in _assert_today
    Eventually(Equals(today.day)))
  File "/usr/lib/python3/dist-packages/testtools/testcase.py", line 423, in assertThat
    raise mismatch_error
testtools.matchers._impl.MismatchError: After 10.0 seconds test failed: 16 != 1

as you can see from failure, fail happens on 16th April, so today is 16, but python is expecting 1.
Which is wrong.

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2015-04-19:

FAILED: Continuous integration, rev:624
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1150/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2627/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/621/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-calendar-app-vivid-amd64-ci/147/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1150/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2015-04-19:

PASSED: Continuous integration, rev:625
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1151/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2628
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2628/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/622
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-vivid-amd64-ci/148

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1151/rebuild

review: Approve (continuous-integration)

Revision history for this message

Kunal Parmar (pkunal-parmar) wrote on 2015-04-22:

It was once approved by Alan so approving it again

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2015-04-22:

FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/ubuntu-calendar-app-autolanding/493/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2633
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2633/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-autolanding/278
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-vivid-amd64-autolanding/65

review: Needs Fixing (continuous-integration)

Revision history for this message

Nicholas Skaggs (nskaggs) wrote on 2015-04-23:

Kunal, ideally we should have a test that covers tapping to create an event. Since event creation is well covered, this test could be written easily enough by opening the dayview and tapping under a few scenarios (on an event, on a blank timeslot, between slots), ensuring the proper response for each.

Revision history for this message

Nicholas Skaggs (nskaggs) wrote on 2015-04-23:

Some suggested changes.

review: Needs Fixing

lp://qastaging/~pkunal-parmar/ubuntu-calendar-app/TapToCreateEvent updated on 2015-04-29