Merge lp://qastaging/~popey/dropping-letters/fix-1196867 into lp://qastaging/dropping-letters

Status: Rejected
Rejected by: Alan Pope 🍺🐧🐱 πŸ¦„
Proposed branch: lp://qastaging/~popey/dropping-letters/fix-1196867
Merge into: lp://qastaging/dropping-letters
Diff against target: 50 lines (+20/-12)
2 files modified
debian/changelog (+6/-0)
dropping-letters.qml (+14/-12)
To merge this branch: bzr merge lp://qastaging/~popey/dropping-letters/fix-1196867
Reviewer Review Type Date Requested Status
Victor Thompson (community) Needs Information
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Dropping Letters developers Pending
Review via email: mp+218136@code.qastaging.launchpad.net

Commit message

Allow exiting the game when we reach the top

Description of the change

I'd recommend some heavy play-testing with this merge :)

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

First pass seems to work fine. Thinking I'd like an AP test for this.

Revision history for this message
Victor Thompson (vthompson) wrote :

I think there are 2 things to look at 1) the header is currently shown in the app. I submitted a bug and a fix for this as I'm the one who broke it... but We might want to retest to make certain that the count of block height is the same. I'm pretty sure it is, however. 2) The game seems to end prior to the last block hitting the stack.. could this be fixed?

review: Needs Information
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

I might conjecture this is no longer needed, as https://code.launchpad.net/~vthompson/dropping-letters/hide-header/+merge/218536 seems to fix everything. Still, we should file a bug to add a test to check for a game over :-)

Revision history for this message
Nicholas Skaggs (nskaggs) wrote :
Revision history for this message
Victor Thompson (vthompson) wrote :

I don't think that MP [1] fixed the issue here. Specifically, what's being done in this MP prevents the user from continuing to play once the game has ended. I believe the issue where the user can keep playing once the game has ended still exists.

[1] https://code.launchpad.net/~vthompson/dropping-letters/hide-header/+merge/218536

Revision history for this message
Victor Thompson (vthompson) wrote :

Just want to clarify if this has been fixed so I can take it off my radar. Until then I'll assume it just needs to merge trunk and be retested.

review: Needs Information
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

Play did not seem to continue after hitting the top when merging your MP[1], but I'll let Alan confirm. Even if it did, this logic may still be needed specific to the bug trying to be solved.

[1] https://code.launchpad.net/~vthompson/dropping-letters/hide-header/+merge/218536

Revision history for this message
Alan Pope 🍺🐧🐱 πŸ¦„ (popey) wrote :

With trunk bzr revno 52 I am still able to carry on playing on flo device after I hit the top and the bong sounds. I'll re-look at this.

Unmerged revisions

51. By Alan Pope 🍺🐧🐱 πŸ¦„

Allow exiting the game when we reach the top

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches