Ubuntu File Manager App

Merge lp://qastaging/~popey/ubuntu-filemanager-app/fix-1288885 into lp://qastaging/ubuntu-filemanager-app

fix-1288885
Merge into trunk

Proposed by Alan Pope 🍺🐧🐱 🦄 on 2014-03-10

Status:

Rejected

Rejected by:

David Planella on 2014-04-15

Proposed branch:

lp://qastaging/~popey/ubuntu-filemanager-app/fix-1288885

Merge into:

lp://qastaging/ubuntu-filemanager-app

Diff against target:

26 lines (+7/-1)

2 files modified

CMakeLists.txt (+1/-1)
debian/changelog (+6/-0)

To merge this branch:

bzr merge lp://qastaging/~popey/ubuntu-filemanager-app/fix-1288885

Undecided

Fix Released

Link a bug report

Reviewer	Review Type	Status
David Planella		Disapprove on 2014-04-15
Alan Pope 🍺🐧🐱 🦄 (community)		Approve on 2014-04-01
Ubuntu Phone Apps Jenkins Bot	continuous-integration	Needs Fixing on 2014-03-18
Review via email: mp+210173@code.qastaging.launchpad.net

Commit message

fix lp:1288885

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-03-10:

PASSED: Continuous integration, rev:138
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/139/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-trusty/1655
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-filemanager-app-raring-amd64-ci/139
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-filemanager-app-saucy-amd64-ci/139
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-filemanager-app-trusty-amd64-ci/89

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/139/rebuild

review: Approve (continuous-integration)

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-03-18:

FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/ubuntu-filemanager-app-autolanding/48/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-trusty/1792
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-filemanager-app-raring-amd64-autolanding/48
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-filemanager-app-saucy-amd64-autolanding/48
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-filemanager-app-trusty-amd64-autolanding/35

review: Needs Fixing (continuous-integration)

Revision history for this message

Alan Pope 🍺🐧🐱 🦄 (popey) on 2014-04-01:

review: Approve

Revision history for this message

David Planella (dpm) wrote on 2014-04-15:

Thanks for the fix. This has now been addressed differently in trunk: the app now builds the plugin and it is started by an executable instead of using qmlscene.

review: Disapprove