Ubuntu Test Cases

Merge lp://qastaging/~psivaa/ubuntu-test-cases/touch-wifi-reboot into lp://qastaging/ubuntu-test-cases/touch

  1. touch-wifi-reboot
  2. Merge into touch
Proposed by Para Siva
Status: Merged
Approved by: Para Siva
Approved revision: 421
Merged at revision: 418
Proposed branch: lp://qastaging/~psivaa/ubuntu-test-cases/touch-wifi-reboot
Merge into: lp://qastaging/ubuntu-test-cases/touch
Diff against target: 18 lines (+8/-0)
1 file modified
scripts/provision.sh (+8/-0)
To merge this branch: bzr merge lp://qastaging/~psivaa/ubuntu-test-cases/touch-wifi-reboot
Reviewer Review Type Date Requested Status
Francis Ginther Approve
Paul Larson Approve
Review via email: mp+280950@code.qastaging.launchpad.net

Commit message

Add a device reboot when network setup fails after retries

Description of the change

For https://trello.com/c/mmnZyxAP/904-vanguard-transient-network-failures-break-phone-autopilot-testing. Add a device reboot when all the retries failed to setup network.

To post a comment you must log in.
Revision history for this message
Paul Larson (pwlars) wrote :

Just out of curiosity, were you able to reproduce the problem and confirm that rebooting like this really helps? We should probably fix retry to return an error to the caller rather than exit, but I don't see any harm in doing this, given that this code has about one more day to live.

review: Approve
Revision history for this message
Para Siva (psivaa) wrote :

Thanks for the review Paul. I tried a few times to *reproduce* the issue but could not. I took Francis's word for the cause and solution for this in https://trello.com/c/mmnZyxAP/904-vanguard-transient-network-failures-break-phone-autopilot-testing.
I did a few tests to make sure that this change does not break anything though. As you said the left span of this change is special :)
http://s-jenkins.ubuntu-ci:8080/job/generic-deb-autopilot-runner-vivid-touch/4521/console
http://s-jenkins.ubuntu-ci:8080/job/psivaa-generic-deb-autopilot-runner-vivid-touch/3/console
http://s-jenkins.ubuntu-ci:8080/job/psivaa-generic-deb-autopilot-runner-vivid-touch/4/console

Revision history for this message
Francis Ginther (fginther) wrote :

This should work. I was able to confirm that the reboots do happen if it can't setup the network and there are no reboots if networking works on the first try. The problem itself is difficult to reproduce, but this gives us a good shot to workaround the problem if comes up again.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches