Merge lp://qastaging/~psivaa/uci-engine/swift-failure-exposure into lp://qastaging/uci-engine

Proposed by Para Siva
Status: Merged
Approved by: Para Siva
Approved revision: 915
Merged at revision: 914
Proposed branch: lp://qastaging/~psivaa/uci-engine/swift-failure-exposure
Merge into: lp://qastaging/uci-engine
Diff against target: 98 lines (+64/-0)
2 files modified
test_runner/tstrun/run_worker.py (+4/-0)
test_runner/tstrun/tests/test_worker.py (+60/-0)
To merge this branch: bzr merge lp://qastaging/~psivaa/uci-engine/swift-failure-exposure
Reviewer Review Type Date Requested Status
Vincent Ladeuil (community) Approve
Joe Talbott (community) Approve
Review via email: mp+245745@code.qastaging.launchpad.net

Commit message

To ensure that we do not swallow the swiftclient related exceptions in the test runner worker

Description of the change

To ensure that we do not swallow the swiftclient related exceptions in the test runner worker. Any client error response in swiftclient during file uploads (save_artefact) is raised in data_store as an exception and this MP disables catching that exception in test runner.

The failure analysis, in http://bazaar.launchpad.net/~vila/uci-engine/analysis/view/head:/tasks.rst lists 3 types of possible failures swift related.
1. PUT can fail with 401 (tested with this MP)
2. ail to upload because we can't reset content (this should also raise client exception and therefore will be tested with the same test)
3. Failure due to connecting to keystone (this is being handled by some other tasks)

To post a comment you must log in.
Revision history for this message
Joe Talbott (joetalbott) wrote :

This looks good to me.

review: Approve
Revision history for this message
Vincent Ladeuil (vila) wrote :

See inline comment for one fix, otherwise, well done, good to land.

Revision history for this message
Vincent Ladeuil (vila) wrote :

And I vote...

review: Needs Fixing
914. By Para Siva

Log before raising the exception

Revision history for this message
Para Siva (psivaa) wrote :

Thanks for that. Fixed that in r914.

Revision history for this message
Vincent Ladeuil (vila) wrote :

Thanks !

review: Approve
Revision history for this message
Vincent Ladeuil (vila) wrote :

pep8 ?

915. By Para Siva

pyflakes fix

Revision history for this message
Para Siva (psivaa) wrote :

pyflakes :) thanks

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches