UTAH

Merge lp://qastaging/~psivaa/utah/upgrade-setup-jobs into lp://qastaging/~utah/utah/jenkins-upgradetest-setup

  1. upgrade-setup-jobs
  2. Merge into jenkins-upgradetest-setup
Proposed by Para Siva
Status: Merged
Merged at revision: 32
Proposed branch: lp://qastaging/~psivaa/utah/upgrade-setup-jobs
Merge into: lp://qastaging/~utah/utah/jenkins-upgradetest-setup
Diff against target: 466 lines (+280/-66)
4 files modified
jenkins/config.xml.jinja2 (+22/-2)
jenkins/production.py (+182/-0)
jenkins/setup_jenkins.py (+75/-63)
upgrade/release_upgrade/tc_control (+1/-1)
To merge this branch: bzr merge lp://qastaging/~psivaa/utah/upgrade-setup-jobs
Reviewer Review Type Date Requested Status
Paul Larson Approve
Para Siva (community) Needs Resubmitting
Review via email: mp+193617@code.qastaging.launchpad.net

Description of the change

This is to give *some flexibility to create upgrade jobs from any base release to the dev release. This cycle being lts, we need jobs from precise. Tried locally and was able to create jobs without issues.

This also includes the timeout change to 3 hrs. So this could supersede, https://code.launchpad.net/~psivaa/utah/upgrade-timeout/+merge/193572

To post a comment you must log in.
Revision history for this message
Andy Doan (doanac) wrote :

There's nothing wrong with this:

105 + epilog=("For example:\n"
106 + "\t%(prog)s -b /path/to/branch"
107 + " -u user -p pass -j http://jenkins:8080"
108 + " -B saucy"
109 + " -D trusty\n"),

However, python has textwrap.dedent which would make this look a little nicer like:

  epilog=('''For example:\n
          t%(prog)s -b /path/to/branch
            -u user -p pass -j http://jenkins:8080
            -B saucy
            -D trusty'''),

Revision history for this message
Andy Doan (doanac) wrote :

I'm not a huge fan of how permutations was changed. Seems like it makes it easier to screw something up with a typo. We moved away from a similar approach in lp:ubuntu-test-cases/touch.

I have no objections if you like this way more though.

Revision history for this message
Paul Larson (pwlars) wrote :

What's up with main and universe? I know they take some additional hand-holding to get up and running, but I don't like commenting them out from the setup script. Default should be that they are ON, and if we need to work around them temporarily, that's fine. But I'm afraid if they are just commented out in the setup script, then they could be too easily forgotten in the future.

lp://qastaging/~psivaa/utah/upgrade-setup-jobs updated
31. By Para Siva

Review comment fixes including using matrices

32. By Para Siva

Keeping local host as the default jenkins

Revision history for this message
Para Siva (psivaa) wrote :

Thanks for the comments, I've tried fixing the concerns in them. I have included to use explicit matrices for each type of upgrade jobs and that includes main and universe as well. Making the main and universe work still needs to be done in terms of creating the base install properly. That will be time consuming but that's on the list.

Note: I have not included a README, but that i'll do after doing some higher priority tasks.

Could you please look at the changes again. Thanks.

review: Needs Resubmitting
Revision history for this message
Paul Larson (pwlars) wrote :

Looks good, assuming you've tried it and jenkins doesn't complain.

review: Approve
Revision history for this message
Para Siva (psivaa) wrote :

Thanks Paul. Yes I was able to create jobs in jiufeng.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: