Merge lp://qastaging/~pundiramit/lava-android-test/binder into lp://qastaging/lava-android-test

did not see the use of the DEFAULT_OPTIONS.

If you just need to check the command exit status,
you can only put the binder.sh in lava_android_test/test_definitions/shells directory,
that's enough.
and then you can use
    lava-android-test install shell-binder
    lava-android-test run shell-binder
as other normall test.

you don't nee the binder.py file the binder directory.

Sorry for that I did not described clearly before if I understant correctly here.

Thanks liuyq. "shell-binder" seems to be a better option in a case where only PASS/FAIL matters. Can the output/metric of a "shell-command" be displayed as a test result as well?

As wrote in the mail, I suggest you add my modification following to make
lava-android-test support more result patterns.

The shell-xxx tests still not support this feature.
But if you like, you can have it with a simple modification.

And I strongly suggest you do following modification on your binder test
this time:

(buildout)09:34:41 liuyq:lava-android-test$ bzr diff
lava_android_test/provider.py
=== modified file 'lava_android_test/provider.py'
--- lava_android_test/provider.py 2012-12-06 11:02:22 +0000
+++ lava_android_test/provider.py 2013-01-21 01:34:40 +0000
@@ -224,8 +224,6 @@
                      'shell chmod 777 %s' % test_sh_android_path]

         ADB_SHELL_STEPS = ['%s $(OPTIONS)' % test_sh_android_path]
- PATTERN = ("^\s*(?P<test_case_id>\S+)="
-
"(?P<result>(pass|fail|ok|ng|true|false|skip|done))\s*$")

         testobj = self.gen_testobj(
                     testname=test_name,
@@ -233,7 +231,7 @@
                                 steps_adb_pre=INSTALL_STEPS_ADB_PRE),
                     runner=testdef.AndroidTestRunner(
                                     adbshell_steps=ADB_SHELL_STEPS),
- parser=testdef.AndroidTestParser(PATTERN),
+ parser=testdef.AndroidSimpleTestParser(),
                     adb=ADB(serial))
         return testobj

(buildout)09:34:48 liuyq:lava-android-test$

This will make lava-android-test support following test result patterns:

test_case_id=result
test_case_id=measurement
test_case_id=measurement units

Could you help to integrate the above modification into your binder test?

On 21 January 2013 02:02, Amit Pundir <email address hidden> wrote:

> Thanks liuyq. "shell-binder" seems to be a better option in a case where
> only PASS/FAIL matters. Can the output/metric of a "shell-command" be
> displayed as a test result as well?
> --
>
> https://code.launchpad.net/~pundiramit/lava-android-test/binder/+merge/144010
> Your team Linaro Validation Team is subscribed to branch
> lp:lava-android-test.
>

--
Thanks,
Yongqin Liu
---------------------------------------------------------------
#mailing list
<email address hidden> <email address hidden>
http://lists.linaro.org/mailman/listinfo/linaro-android
<email address hidden> <email address hidden>
http://lists.linaro.org/pipermail/linaro-validation

liuyq I have pushed your change as well. Do you think I should go ahead with this change or submit a new change with a simple "shell-binder" implementation?

> liuyq I have pushed your change as well. Do you think I should go ahead with
> this change or submit a new change with a simple "shell-binder"
> implementation?

Push to this branch is OK.
And for this change, you need to move the binder.sh to shells directory,
and delete the binder directory and binder.py, they are not needed again.

95 + echo "binder=PASS";
Please change to
     echo "binder=pass"
97 + echo "binder=FAIL";
Please change to
     echo "binder=fail"

because only the lower case is supported now.

liuyq please review the changes.

thanks