Linaro Android Build Tools

Merge lp://qastaging/~pundiramit/linaro-android-build-tools/bootloadertype into lp://qastaging/linaro-android-build-tools

  1. bootloadertype
  2. Merge into trunk
Proposed by Amit Pundir
Status: Merged
Approved by: Milo Casagrande
Approved revision: 684
Merged at revision: 681
Proposed branch: lp://qastaging/~pundiramit/linaro-android-build-tools/bootloadertype
Merge into: lp://qastaging/linaro-android-build-tools
Diff against target: 21 lines (+6/-0)
1 file modified
build-scripts/post-build-lava.py (+6/-0)
To merge this branch: bzr merge lp://qastaging/~pundiramit/linaro-android-build-tools/bootloadertype
Reviewer Review Type Date Requested Status
Milo Casagrande (community) Approve
vishal (community) Approve
Yongqin Liu Pending
khasim syed mohammed Pending
Review via email: mp+192091@code.qastaging.launchpad.net
To post a comment you must log in.
lp://qastaging/~pundiramit/linaro-android-build-tools/bootloadertype updated
682. By Amit Pundir

Add bootloader type parameter for deploy_linaro_android_image command while submitting jobs. Default: u_boot

Revision history for this message
vishal (vishalbhoj) wrote :

Is this change mandatory to the job ? Not all platform have u-boot by default. Some have proprietary bootloader and communicate with fastboot protocol. It should not be set to u-boot by default if its not a mandatory parameter.

Revision history for this message
Amit Pundir (pundiramit) wrote :

It is mandatory for the jobs which use uefi e.g new Juice models.

Revision history for this message
Amit Pundir (pundiramit) wrote :

And if a build does not want to fall back to u_boot then it should define BOOTLOADER_TYPE in the build config.

Revision history for this message
Amit Pundir (pundiramit) wrote :

I'll remove the part where I set u_boot as default bootloadertype and resubmit the change.

lp://qastaging/~pundiramit/linaro-android-build-tools/bootloadertype updated
683. By Amit Pundir

Add bootloader type parameter for deploy_linaro_android_image command while submitting jobs. Do not set any defaults.

684. By Amit Pundir

Do not set any default bootloader

Revision history for this message
vishal (vishalbhoj) :
review: Approve
Revision history for this message
Milo Casagrande (milo) wrote :

Looks good, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches