Linaro Android Build Tools

Merge lp://qastaging/~pundiramit/linaro-android-build-tools/user-build-script into lp://qastaging/linaro-android-build-tools

  1. user-build-script
  2. Merge into trunk
Proposed by Amit Pundir
Status: Merged
Approved by: Paul Sokolovsky
Approved revision: 543
Merged at revision: 543
Proposed branch: lp://qastaging/~pundiramit/linaro-android-build-tools/user-build-script
Merge into: lp://qastaging/linaro-android-build-tools
Diff against target: 107 lines (+51/-5)
1 file modified
build-scripts/create-user-build-script (+51/-5)
To merge this branch: bzr merge lp://qastaging/~pundiramit/linaro-android-build-tools/user-build-script
Reviewer Review Type Date Requested Status
Paul Sokolovsky Approve
Linaro Infrastructure Pending
Review via email: mp+139409@code.qastaging.launchpad.net

Description of the change

This Merge Proposal update user build script to support linaro-android builds on 64 bit Ubuntu 10.04, 12.04 and 12.10 versions.

To post a comment you must log in.
lp://qastaging/~pundiramit/linaro-android-build-tools/user-build-script updated
542. By Amit Pundir

Update user build script to clone from linaro-private git repos

543. By Amit Pundir

Update user build script to prompt for login-id

Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

Having updated list of packages required for build as well as check for x86_64 is definitely good. But I'm not sure about supporting access to linaro-private. The original idea of user build script was to simplify build process for outside/3rd-party users. But outside users are not supposed to have access to private Linaro repos at all, so I'm not sure if conveniencing access for them makes sense. So, I'd like to know what are the requirements/user stories behind this change.

review: Needs Information
Revision history for this message
Amit Pundir (pundiramit) wrote :

Right now outside/3rd party users can decode http:// link of git projects from manifest files anyways, though they can not access it. How to protect manifest files is a different task all together, which is currently been worked on.

3rd party developers can clone only public projects from linaro Git manifests and they will get public-key denied error for private projects.

Idea behind this change is to facilitate authorized linaro assignees to get access to private-repos and simplify their build experience.

Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

I see, sounds good, and sorry for delay.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches