Ubuntu
openjdk-lts package

Merge ~pushkarnk/ubuntu/+source/openjdk-lts:merge-2023739-2025733-lts into ubuntu/+source/openjdk-lts:ubuntu/devel

  1. Git
  2. lp:~pushkarnk/ubuntu/+source/openjdk-lts
  3. merge-2023739-2025733-lts
  4. Merge into ubuntu/devel
Proposed by Pushkar Kulkarni
Status: Needs review
Proposed branch: ~pushkarnk/ubuntu/+source/openjdk-lts:merge-2023739-2025733-lts
Merge into: ubuntu/+source/openjdk-lts:ubuntu/devel
Prerequisite: ~pushkarnk/ubuntu/+source/openjdk-lts:new-upstream
Diff against target: 7116 lines (+3436/-3450)
8 files modified
debian/changelog (+22/-0)
debian/control (+6/-6)
debian/control.in (+5/-5)
debian/copyright (+3366/-3372)
debian/patches/alpha-float-const.diff (+13/-0)
debian/rules (+24/-12)
debian/watch (+0/-1)
dev/null (+0/-54)
Reviewer Review Type Date Requested Status
Dave Jones (community) Needs Information
Vladimir Petko (community) Approve
Matthias Klose Pending
git-ubuntu import Pending
Review via email: mp+446458@code.qastaging.launchpad.net

Commit message

Merge some 11.0.19+7 leftovers and 11.0.20+7.

To post a comment you must log in.
Revision history for this message
Pushkar Kulkarni (pushkarnk) wrote :

Building in https://launchpad.net/~pushkarnk/+archive/ubuntu/jdk-lts-11.0.20+7

Reply
Revision history for this message
Vladimir Petko (vpa1977) wrote :

Looks good, just one version comment but as I can not merge you need other reviewer.

Reply
Revision history for this message
Vladimir Petko (vpa1977) wrote :

Just one small version comment, but since it is technically Ubuntu-only package we can keep the suffix.

review: Approve
Reply
Revision history for this message
Dave Jones (waveform) wrote :

I may be misunderstanding something here, but why do we have changes for architectures we don't care about, like ia64, powerpcspe, and alpha?

review: Needs Information
Reply
Revision history for this message
Pushkar Kulkarni (pushkarnk) wrote (last edit ):

> I may be misunderstanding something here, but why do we have changes for
> architectures we don't care about, like ia64, powerpcspe, and alpha?

Hmm, an alpha/powerpcspe-specific patch was removed. I guess that should be OK? As for the ia64-specific change I'd be curious about Vladimir's opinion.

Reply
Revision history for this message
Vladimir Petko (vpa1977) wrote :

> I may be misunderstanding something here, but why do we have changes for
> architectures we don't care about, like ia64, powerpcspe, and alpha?

The issue i think is historical and maybe we could plan transitioning to openjdk-11 packagage that we could sync as opposed to doing the merges in openjdk-lts.
The contents of the package should be a verbatim copy of the Debian openjdk-11 package (hence unsupported arches).

Reply
Revision history for this message
Dave Jones (waveform) wrote :

> Hmm, an alpha/powerpcspe-specific patch was removed. I guess that should be OK? As for the ia64-specific change I'd be curious about Vladimir's opinion.

It would indeed be fine to remove a patch for an architecture we don't support (like the alpha/powerpcspe patch), in so far as it shouldn't make any difference to us. However, I'm more concerned that we're introducing a delta (that we'll have to maintain going forward) with upstream for no specific reason?

The same goes for things like the ia64 configuration archs; we don't build for ia64 so why are we introducing changes for it?

Reply
Revision history for this message
Dave Jones (waveform) wrote :

> The contents of the package should be a verbatim copy of the Debian openjdk-11 package (hence unsupported arches).

As Vladimir points out, ideally this should be a verbatim copy of the upstream Debian package. What I don't understand is why we'd deviate from upstream for archs we don't care about. Or am I misunderstanding these changes? Do these changes actually originate from the Debian package?

Reply
Revision history for this message
Matthias Klose (doko) wrote :

we are taking these for any other openjdk-N package as well. Why would you explicitly remove selected patches from the packaging?

Reply

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches