Merge ~pwlars/checkbox/+git/support:more-pmr-fixes into ~checkbox-dev/checkbox/+git/support:master

Proposed by Paul Larson
Status: Merged
Approved by: Paul Larson
Approved revision: 31bea573a7303b48115e3d66f6ce9d5193e13d34
Merged at revision: 1c7d55bc290efe430d0620880d39dfd15c43f476
Proposed branch: ~pwlars/checkbox/+git/support:more-pmr-fixes
Merge into: ~checkbox-dev/checkbox/+git/support:master
Diff against target: 51 lines (+4/-10)
2 files modified
get-external-tarballs (+1/-7)
install-pip-from-source (+3/-3)
Reviewer Review Type Date Requested Status
Sylvain Pineau (community) Approve
Review via email: mp+333972@code.qastaging.launchpad.net

Description of the change

I've created the closest thing I can to a test environment for this, and used this, plus my other changes at https://github.com/checkbox/external-tarballs/pull/6/files to test the following projects:

checkbox-ng
plainbox
plainbox-provider-snappy
plainbox-provider-plano

These changes resolve the corner cases that some of these seemed to be having on trusty, and most importantly, the ones related to proxy access and older versions of urllib3/pip/requests

I *think* this should work for hwcert now, but it's hard to know for sure if there's still some other corner case out there.

To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

+1

review: Approve

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches