Merge ~pwlars/checkbox/+git/support:avoid-path-conflict into ~checkbox-dev/checkbox/+git/support:master

Proposed by Paul Larson
Status: Merged
Approved by: Paul Larson
Approved revision: 66f3a97208d599657e372ea53217ca1017c69ddd
Merged at revision: 22caba2a24682f80b3ff1f472c3ed51d433fda66
Proposed branch: ~pwlars/checkbox/+git/support:avoid-path-conflict
Merge into: ~checkbox-dev/checkbox/+git/support:master
Diff against target: 49 lines (+6/-4)
1 file modified
test-in-lxc.sh (+6/-4)
Reviewer Review Type Date Requested Status
Maciej Kisielewski (community) Approve
Review via email: mp+359957@code.qastaging.launchpad.net

Description of the change

I think the most recent errors we see are because some projects call things that cache files in $HOME/.cache, .local, etc. Because we were bind mounting to that directory, things like this could be unsafe. I was able to reproduce that occasionally by running the plainbox-provider-snappy tests, but with this patch, I can't reproduce it. Also, I added a few more safeguards against apt/dpkg locks to prevent auto-updating.

To post a comment you must log in.
Revision history for this message
Maciej Kisielewski (kissiel) wrote :

Looks good! +1

review: Approve

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches