Merge ~pwlars/checkbox/+git/support:wait-for-lxd-up-better-er-er into ~checkbox-dev/checkbox/+git/support:master
Proposed by
Paul Larson
| Status: | Merged |
|---|---|
| Approved by: | Paul Larson |
| Approved revision: | b9337d13544b6213e72d0fc5a5f8e5a0989e3192 |
| Merged at revision: | b761b84efb7418d3cd67b736e05fca95b0ecd1cf |
| Proposed branch: | ~pwlars/checkbox/+git/support:wait-for-lxd-up-better-er-er |
| Merge into: | ~checkbox-dev/checkbox/+git/support:master |
| Diff against target: |
29 lines (+9/-3) 1 file modified
test-in-lxc.sh (+9/-3) |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Jonathan Cave (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Found one spot in the previous commit where I should have also tested the network this new way and didn't yet. Also found a corner case where if there's no "inet" section in addresses[] it will silently fail with a null value. Adding -e to jq will make it fail properly in that situation
To post a comment you must log in.
There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Not saying we should do it now, but i found pylxd to actually be pretty useful for working with lxd and gathering information - simpler than messing around with bash. We could consider moving to python for this script at some point.
+1 on this though