Merge lp://qastaging/~pwlars/qa-dashboard/use-hostnames into lp://qastaging/qa-dashboard

Proposed by Paul Larson
Status: Merged
Approved by: Chris Johnston
Approved revision: 683
Merged at revision: 681
Proposed branch: lp://qastaging/~pwlars/qa-dashboard/use-hostnames
Merge into: lp://qastaging/qa-dashboard
Diff against target: 78 lines (+9/-9)
3 files modified
common/tests/test_dashboard_extras.py (+3/-3)
smokeng/config.py (+2/-2)
smokeng/tests.py (+4/-4)
To merge this branch: bzr merge lp://qastaging/~pwlars/qa-dashboard/use-hostnames
Reviewer Review Type Date Requested Status
Chris Johnston Approve
PS Jenkins bot continuous-integration Approve
Paul Larson Needs Resubmitting
Review via email: mp+195685@code.qastaging.launchpad.net

Commit message

Use hostnames instead of IP addresses for the jenkins servers when logged in.

To post a comment you must log in.
Revision history for this message
Chris Johnston (cjohnston) wrote :

Tests.. :-( Also please add a comment for the MP in LP

review: Needs Fixing
682. By Paul Larson

modify the tests to look for the hostname too

Revision history for this message
Paul Larson (pwlars) :
review: Needs Resubmitting
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:681
http://s-jenkins:8080/job/dashboard-ci/255/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins:8080/job/dashboard-ci/255/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:682
http://s-jenkins:8080/job/dashboard-ci/256/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins:8080/job/dashboard-ci/256/rebuild

review: Needs Fixing (continuous-integration)
683. By Paul Larson

Fix tests under common/tests/test_dashboard_extras.py to use hostnames too

Revision history for this message
Paul Larson (pwlars) :
review: Needs Resubmitting
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:683
http://s-jenkins:8080/job/dashboard-ci/257/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins:8080/job/dashboard-ci/257/rebuild

review: Approve (continuous-integration)
Revision history for this message
Chris Johnston (cjohnston) wrote :

Thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches