Ubuntu Test Cases

Merge lp://qastaging/~pwlars/ubuntu-test-cases/auto-offline-devs-per-jenkins into lp://qastaging/ubuntu-test-cases/touch

  1. auto-offline-devs-per-jenkins
  2. Merge into touch
Proposed by Paul Larson
Status: Merged
Merged at revision: 315
Proposed branch: lp://qastaging/~pwlars/ubuntu-test-cases/auto-offline-devs-per-jenkins
Merge into: lp://qastaging/ubuntu-test-cases/touch
Diff against target: 92 lines (+50/-0)
1 file modified
scripts/recover.py (+50/-0)
To merge this branch: bzr merge lp://qastaging/~pwlars/ubuntu-test-cases/auto-offline-devs-per-jenkins
Reviewer Review Type Date Requested Status
Francis Ginther Approve
Evan (community) Approve
Paul Larson Needs Resubmitting
Para Siva (community) Approve
Review via email: mp+237717@code.qastaging.launchpad.net

Description of the change

This will, of course, need the yaml file referenced here to be installed by the charm, but it should also be safe to run even if that file doesn't exist, or has bad data

To post a comment you must log in.
Revision history for this message
Para Siva (psivaa) wrote :

Thanks for the work. looks good to me. Good that we offline the device if its not in adb even without relay info. ++1

review: Approve
Revision history for this message
Evan (ev) wrote :

Approve, but I think we can make this more robust in a follow-up MP. See inline comment.

review: Approve
lp://qastaging/~pwlars/ubuntu-test-cases/auto-offline-devs-per-jenkins updated
315. By Paul Larson

Add a retry loop if we can't contact jenkins to mark the device offline

Revision history for this message
Paul Larson (pwlars) wrote :

How about something like this for the retry?

review: Needs Resubmitting
Revision history for this message
Evan (ev) wrote :

That's great, thank you.

review: Approve
Revision history for this message
Francis Ginther (fginther) wrote :

Looks good, thanks for putting extra effort into the retry logic. I just had a minor comment on the error messages when the retries run out, but something that can be addressed later (obviously as this has been merged :-) ).

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches