Merge lp://qastaging/~pwlars/ubuntu-test-cases/relay-bank-pins into lp://qastaging/ubuntu-test-cases/touch

Proposed by Paul Larson
Status: Merged
Approved by: Paul Larson
Approved revision: 414
Merged at revision: 413
Proposed branch: lp://qastaging/~pwlars/ubuntu-test-cases/relay-bank-pins
Merge into: lp://qastaging/ubuntu-test-cases/touch
Diff against target: 293 lines (+112/-59)
1 file modified
scripts/device_info.py (+112/-59)
To merge this branch: bzr merge lp://qastaging/~pwlars/ubuntu-test-cases/relay-bank-pins
Reviewer Review Type Date Requested Status
Francis Ginther Approve
Review via email: mp+273753@code.qastaging.launchpad.net

Commit message

Allow relay banks to be associated with the pin

Description of the change

Some devices are connected to relays on more than one 'bank'. The existing setup only allows us to specify the bank once for the whole device, so we need a way to say "this pin is on bank0, this other pin is on bank1". This is the most sensible way I could think of to do it, but I'm open to suggestions.

To post a comment you must log in.
Revision history for this message
Francis Ginther (fginther) wrote :

Looks good. I assume krillin-13 will be added with a different MP.

review: Approve
Revision history for this message
Paul Larson (pwlars) wrote :

Yes, definitely

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches