Merge lp://qastaging/~pwlars/ubuntu-test-cases/touch-refactor-recovery into lp://qastaging/ubuntu-test-cases/touch
Proposed by
Paul Larson
| Status: | Merged |
|---|---|
| Merged at revision: | 318 |
| Proposed branch: | lp://qastaging/~pwlars/ubuntu-test-cases/touch-refactor-recovery |
| Merge into: | lp://qastaging/ubuntu-test-cases/touch |
| Diff against target: |
449 lines (+158/-152) 3 files modified
scripts/device_info.py (+129/-42) scripts/get-device-info (+4/-9) scripts/recover.py (+25/-101) |
| To merge this branch: | bzr merge lp://qastaging/~pwlars/ubuntu-test-cases/touch-refactor-recovery |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Francis Ginther | Approve | ||
| Paul Larson | Needs Resubmitting | ||
|
Review via email:
|
|||
Description of the change
This is something I've been meaning to do for a while, and I believe it will help get this code in a better state for doing unit tests on it. As I was looking at the bits that were needed to add support for krillin recovery though, it was clear that it would work much nicer if I went ahead and did the refactor first.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Thanks for the refactoring, this is easier to understand. I have some comments on some code that was just moved around, feel free to defer these if you want to keep this MP to just the refactoring change.