Merge lp://qastaging/~pwlars/ubuntu-test-cases/utah-sudo-fix-2 into lp://qastaging/ubuntu-test-cases/touch

Proposed by Paul Larson
Status: Merged
Merged at revision: 313
Proposed branch: lp://qastaging/~pwlars/ubuntu-test-cases/utah-sudo-fix-2
Merge into: lp://qastaging/ubuntu-test-cases/touch
Diff against target: 67 lines (+40/-15)
1 file modified
scripts/jenkins.sh (+40/-15)
To merge this branch: bzr merge lp://qastaging/~pwlars/ubuntu-test-cases/utah-sudo-fix-2
Reviewer Review Type Date Requested Status
Evan (community) Approve
Review via email: mp+237141@code.qastaging.launchpad.net

Description of the change

This is just so that we can kill the utah dependency on sudo. After this, I think the only one we have left is pbuilder. Kind of brute force, but it works. Once we get all this converted to adt, we can eliminate this script anyway.

To post a comment you must log in.
Revision history for this message
Evan (ev) wrote :

Some complaints, but otherwise +1.

review: Approve
Revision history for this message
Evan (ev) :
Revision history for this message
Paul Larson (pwlars) wrote :

I'll fix up the quoting and use $USER instead. Thanks for the comments. It turns out that the previously used approach *does* work properly (there's not a bug there as you fear where it chowns everything to root) but I do agree that your method is way better.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches