Merge lp://qastaging/~quequotion/slingshot/fix-1635776 into lp://qastaging/~elementary-pantheon/slingshot/trunk
Status: | Rejected |
---|---|
Rejected by: | Cody Garver |
Proposed branch: | lp://qastaging/~quequotion/slingshot/fix-1635776 |
Merge into: | lp://qastaging/~elementary-pantheon/slingshot/trunk |
Diff against target: |
106 lines (+20/-12) 1 file modified
src/SlingshotView.vala (+20/-12) |
To merge this branch: | bzr merge lp://qastaging/~quequotion/slingshot/fix-1635776 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Cody Garver (community) | Disapprove | ||
Santiago (community) | Needs Fixing | ||
Danielle Foré | Needs Fixing | ||
Kirill Romanov (community) | test | Needs Fixing | |
Review via email: mp+310705@code.qastaging.launchpad.net |
Commit message
gandalfn (2016-05-06):
The scroll and key press/release event forwading from event box does not
work on debian testing.
Activate the default event mask for this events for event box.
Disconnect search entry key press/release event from event forwarding.
Send key press/release event forwarding from event box to search entry in all case.
Description of the change
Update, rebased on upstream and gandalfn's branch:
Give event_box proper event masks, remove (redundant?) "search_
Previously:
use "im_context_
//scrolling over the application icons probably requires the eventbox
Unmerged revisions
- 706. By quequotion
-
gandalfn's patch retry
- 705. By quequotion
-
Rebase
- 704. By quequotion
-
Revert last
- 703. By quequotion
-
gandalfn's fix, slightly updated
It broke scrolling for me.