Merge lp://qastaging/~radonapps/dialer-app/keyentry_clear into lp://qastaging/dialer-app
Proposed by
Daniyaal Rasheed
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://qastaging/~radonapps/dialer-app/keyentry_clear |
| Merge into: | lp://qastaging/dialer-app |
| Diff against target: |
102 lines (+13/-12) 2 files modified
src/qml/DialerPage/DialerPage.qml (+2/-1) src/qml/dialer-app.qml (+11/-11) |
| To merge this branch: | bzr merge lp://qastaging/~radonapps/dialer-app/keyentry_clear |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Tiago Salem Herrmann (community) | Needs Fixing | ||
|
Review via email:
|
|||
Description of the change
Keypad Entry is passed by reference to the call function so that the value can be cleared inside the function when a call successfully initiates.
To post a comment you must log in.
Unmerged revisions
- 509. By Daniyaal Rasheed
-
Fixed issues with clearing keypadEntry before USSD returns
- 508. By Daniyaal Rasheed
-
keypadEntry is cleared when after the user successfully starts a call
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Thanks for the patch.
Unfortunately the original bug remains. The keypad entry still contains the value after an USSD command is invoked. (it returns before keypadEntry.value is cleared)
Apart from that, there is one place where you forgot to replace "number" by keypadEntry.value.
To make the diff smaller you could define var number = keypadEntry.value in the beginning of call().
As a suggestion, how about return true or false in the call() function (indicating if the number was actually called) and in DialerPage.qml simply clear the entry if the call method returned true?