Merge ~rafaeldtinoco/ubuntu/+source/ipxe:ipxe-focal-merge into ubuntu/+source/ipxe:ubuntu/focal-devel

Proposed by Rafael David Tinoco
Status: Merged
Approved by: Christian Ehrhardt 
Approved revision: ae6d20a0552ca50d85dc03afc82c30a8b1efff37
Merge reported by: Christian Ehrhardt 
Merged at revision: ae6d20a0552ca50d85dc03afc82c30a8b1efff37
Proposed branch: ~rafaeldtinoco/ubuntu/+source/ipxe:ipxe-focal-merge
Merge into: ubuntu/+source/ipxe:ubuntu/focal-devel
Diff against target: 52 lines (+28/-2)
2 files modified
debian/changelog (+13/-0)
debian/tree/ipxe/etc/grub.d/20_ipxe (+15/-2)
Reviewer Review Type Date Requested Status
Christian Ehrhardt  (community) Approve
Canonical Server packageset reviewers Pending
Canonical Server Core Reviewers Pending
Canonical Server Pending
Review via email: mp+377540@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Thanks for picking those up and combining those

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

The code of Alkis LGTM but it is complex, therefore I asked you to test it a while a go and that all looked good.
Therefore +1 to that part.

The ipxe id is a small, but helpful change for our users.
I double checked https://www.gnu.org/software/grub/manual/grub/grub.html#menuentry for side effects but I think it is useful and has no drawback.

ack to both parts of this.

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Changelog LGTM, attribution is ok as well

I found a very minor symbol change to do int he changelog - see inline below

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

I also like that this is all encapsulated into /etc/grub.d/20_ipxe which makes it in the worst case of an issue for most setups easy to work around by removing that file

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Overall +1, please try to use your new tagging and sponsoring powers :-)

review: Approve
Revision history for this message
Rafael David Tinoco (rafaeldtinoco) wrote :

$ git push pkg upload/1.0.0+git-20190109.133f4c4-0ubuntu3
Enumerating objects: 37, done.
Counting objects: 100% (37/37), done.
Delta compression using up to 8 threads
Compressing objects: 100% (17/17), done.
Writing objects: 100% (29/29), 2.65 KiB | 543.00 KiB/s, done.
Total 29 (delta 12), reused 0 (delta 0)
To ssh://git.launchpad.net/~usd-import-team/ubuntu/+source/ipxe
 * [new tag] upload/1.0.0+git-20190109.133f4c4-0ubuntu3 -> upload/1.0.0+git-20190109.133f4c4-0ubuntu3

Revision history for this message
Rafael David Tinoco (rafaeldtinoco) wrote :

$ dput ubuntu ./ipxe_1.0.0+git-20190109.133f4c4-0ubuntu3_source.changes
Checking signature on .changes
gpg: ./ipxe_1.0.0+git-20190109.133f4c4-0ubuntu3_source.changes: Valid signature from A93E0E0AD83C0D0F
Checking signature on .dsc
gpg: ./ipxe_1.0.0+git-20190109.133f4c4-0ubuntu3.dsc: Valid signature from A93E0E0AD83C0D0F
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading ipxe_1.0.0+git-20190109.133f4c4-0ubuntu3.dsc: done.
  Uploading ipxe_1.0.0+git-20190109.133f4c4-0ubuntu3.debian.tar.xz: done.
  Uploading ipxe_1.0.0+git-20190109.133f4c4-0ubuntu3_source.buildinfo: done.
  Uploading ipxe_1.0.0+git-20190109.133f4c4-0ubuntu3_source.changes: done.
Successfully uploaded packages.

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

https://launchpad.net/ubuntu/+source/ipxe/1.0.0+git-20190109.133f4c4-0ubuntu3 started building, consider that one merged and lets track migration the next few hours/days

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches