Merge ~rafaeldtinoco/ubuntu/+source/qemu:lp1805256-focal into ubuntu/+source/qemu:ubuntu/focal-devel

Proposed by Rafael David Tinoco
Status: Merged
Approved by: Rafael David Tinoco
Approved revision: fd9cfa85aabd6e23e3c1b691b1bc55c8f8ac1e7a
Merge reported by: Christian Ehrhardt 
Merged at revision: fd9cfa85aabd6e23e3c1b691b1bc55c8f8ac1e7a
Proposed branch: ~rafaeldtinoco/ubuntu/+source/qemu:lp1805256-focal
Merge into: ubuntu/+source/qemu:ubuntu/focal-devel
Diff against target: 310 lines (+279/-0)
4 files modified
debian/changelog (+8/-0)
debian/patches/series (+2/-0)
debian/patches/ubuntu/lp-1805256-aio-wait_delegate_poll_aioctx_bql.patch (+110/-0)
debian/patches/ubuntu/lp-1805256-async_use_explicit_mem_barriers.patch (+159/-0)
Reviewer Review Type Date Requested Status
Christian Ehrhardt  (community) Approve
Rafael David Tinoco (community) Approve
Ike Panhc (community) Approve
dann frazier (community) Approve
Canonical Server Pending
Review via email: mp+383545@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
Rafael David Tinoco (rafaeldtinoco) wrote :
Revision history for this message
dann frazier (dannf) wrote :

I built the source package from your PPA (faster than waiting for LP builders), and verified that it passes the test (>100 runs so far), so +1. Note that previously I had tested w/o the "aio-wait: delegate polling of main AioContext if BQL not held" patch, and it also passed my test case.

review: Approve
Revision history for this message
Ike Panhc (ikepanhc) wrote :

Test on d06 for 1000 run and all passed

review: Approve
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Also needs a rebase due to CVE-2020-11869 fix in 1:4.2-3ubuntu6.1
It otherwise looks ok to me

review: Needs Fixing
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Can you update the PPA (https://launchpad.net/~rafaeldtinoco/+archive/ubuntu/lp1805256/) after the rebase. I'll then run a regression test set and if ok sponsor it into the -unapproved queue after the groovy upload completed.

Revision history for this message
Rafael David Tinoco (rafaeldtinoco) wrote :

Done!

review: Approve
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Thanks for the rebase, non case specific regression testing is a few thousand tests in and still working.
Approving the MP now.
If no issue shows up late I'll sponsor this to -unapproved later on.

review: Approve
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Regression tests completed - sponsoring once groovy is complete

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Groovy is completed, SRU sponsored into -unapproved

Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading qemu_4.2-3ubuntu6.2.dsc: done.
  Uploading qemu_4.2-3ubuntu6.2.debian.tar.xz: done.
  Uploading qemu_4.2-3ubuntu6.2_source.buildinfo: done.
  Uploading qemu_4.2-3ubuntu6.2_source.changes: done.
Successfully uploaded packages.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches