Merge lp://qastaging/~rafalcieslak256/ubuntu-accomplishments-viewer/NewAPI into lp://qastaging/ubuntu-accomplishments-viewer
Proposed by
Rafał Cieślak
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Merged at revision: | 43 | ||||
| Proposed branch: | lp://qastaging/~rafalcieslak256/ubuntu-accomplishments-viewer/NewAPI | ||||
| Merge into: | lp://qastaging/ubuntu-accomplishments-viewer | ||||
| Diff against target: |
815 lines (+179/-237) 4 files modified
accomplishments-viewer.desktop.in (+1/-1) accomplishments_viewer/AccomplishmentsViewerWindow.py (+112/-169) accomplishments_viewer/EditExtrainfoDialog.py (+8/-8) po/accomplishments-viewer.pot (+58/-59) |
||||
| To merge this branch: | bzr merge lp://qastaging/~rafalcieslak256/ubuntu-accomplishments-viewer/NewAPI | ||||
| Related bugs: |
|
||||
| Related blueprints: |
Reorganizing Accomplishments API
(Medium)
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Jono Bacon | Pending | ||
|
Review via email:
|
|||
Description of the change
This branch implements changes for the New API.
(sorry for having committed changes to .desktop.in and .pot files, they are not needed, and will be automatically regenerated)
* Renamed all references to application, app to collection, col
* Creating the local copy of a part of the database is now done by the daemon (look for changes in _load_accomplis
* Displaying accom details uses not not the data from trophy, but from the daemon's database, which results in description being always in current locale.
* Many optimizations, e.g. the update_views used to be run up to 10 times in a row for no reason. I have also cleaned the code in very few places.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
