Merge lp://qastaging/~raharper/curtin/trunk.zfs-root into lp://qastaging/~curtin-dev/curtin/trunk

Proposed by Ryan Harper
Status: Rejected
Rejected by: Scott Moser
Proposed branch: lp://qastaging/~raharper/curtin/trunk.zfs-root
Merge into: lp://qastaging/~curtin-dev/curtin/trunk
Diff against target: 1629 lines (+1327/-14)
17 files modified
curtin/block/__init__.py (+45/-1)
curtin/block/clear_holders.py (+9/-1)
curtin/block/zfs.py (+302/-0)
curtin/commands/block_meta.py (+75/-2)
curtin/commands/curthooks.py (+16/-3)
curtin/commands/install.py (+4/-0)
curtin/deps/__init__.py (+27/-1)
curtin/util.py (+29/-0)
doc/topics/storage.rst (+138/-0)
examples/tests/zfsroot.yaml (+101/-0)
helpers/common (+7/-1)
tests/unittests/test_block.py (+22/-0)
tests/unittests/test_block_zfs.py (+386/-0)
tests/unittests/test_clear_holders.py (+25/-3)
tests/unittests/test_curthooks.py (+2/-2)
tests/unittests/test_util.py (+74/-0)
tests/vmtests/test_zfsroot.py (+65/-0)
To merge this branch: bzr merge lp://qastaging/~raharper/curtin/trunk.zfs-root
Reviewer Review Type Date Requested Status
Server Team CI bot continuous-integration Approve
curtin developers Pending
Review via email: mp+334786@code.qastaging.launchpad.net

Description of the change

Add zpool, zfs storage command support for ZFS on Root

curtin/block
 - Add get_dev_disk_byid() to return a mapping of devname to disk/by-id paths
 - Add zfs and zpool to install deps dictionary

curtin/block/clear_holders
 - Add modprobe zfs

curtin/block/zfs
 - implement zpool_create, zfs_create, zfs_set, and zfs_mount commands

curtin/commands/block_meta
 - implement handlers for type: zpool and zfs
 - add get_poolname resolver
 - add zfsroot sgdisk partition flag

curtin/commands/curthooks
 - update util.install_package invocations to pass --no-install-recommends
   in all locations except install_kernel(); this prevents zfsutils-linux
   from pulling zfs-dkms which is not needed but recommended in the package
 - Add an injection of a zfs environment variable required for ZFS on rootfs
   to work with grub; allows grub to extract the path to the zfs vdevs full
   path rather than just the devname (/dev/disk/by-id/foo vs disk/by-id/foo)

curtin/commands/install
 - Export ZPOOL_VDEV_NAME_PATH=1 into environment to allow grub to work with
   zfs on root

doc/topics/storage.rst
 - Add documentation for zpool, zfs configuration

helpers/common
 - Update install_grub to skip block-device check if target mountpoint is zfs.

tests/unittests/test_block
 - Add test for disk_byid methods

tests/unittests/test_block_zfs
 - Add coverage for block.zfs

tests/unittests/test_clear_holders
 - Update test to account for modprobe zfs

tests/unittests/test_curthooks
 - Update test to account for install_packages passing --no-install-recommends

tests/vmtests/test_zfsroot
 - Add initial zfsroot install and test

To post a comment you must log in.
545. By Ryan Harper

drop ramsize change, not needed

Revision history for this message
Server Team CI bot (server-team-bot) wrote :
review: Approve (continuous-integration)
546. By Ryan Harper

zfsutils only on xenial and newer

Revision history for this message
Server Team CI bot (server-team-bot) wrote :
review: Approve (continuous-integration)
547. By Ryan Harper

dependencies: add kernel module depedency checks

Revision history for this message
Server Team CI bot (server-team-bot) wrote :
review: Approve (continuous-integration)
548. By Ryan Harper

util add kernel module loading helpers

549. By Ryan Harper

Switch clear_holders to use load_kernel_module

550. By Ryan Harper

fix indentation for zfs fstab entries

551. By Ryan Harper

block: add devs list to blkid command, add is_zfs_member

552. By Ryan Harper

zfs: add zpool_list, zpool_export, device_to_poolname, clear-holders for zfs

553. By Ryan Harper

vmtests: zfsroot enable dirty-disk mode to test clear-holders on zfs

Revision history for this message
Server Team CI bot (server-team-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Scott Moser (smoser) wrote :

Ryan, can you test
 https://code.launchpad.net/~smoser/maas-images/trunk.add-zfs/+merge/335179
That shoudl tell us if we need to modprobe the zfs or not. I really dont think we should.
obviously its not a big deal (the modprobe), but better if we don't have code that isnt necessary and then we're afraid to remove later.

there are lots of inline comments there. most are only cursory or involved in my reading not related to code.

Revision history for this message
Scott Moser (smoser) wrote :

Unmerged revisions

553. By Ryan Harper

vmtests: zfsroot enable dirty-disk mode to test clear-holders on zfs

552. By Ryan Harper

zfs: add zpool_list, zpool_export, device_to_poolname, clear-holders for zfs

551. By Ryan Harper

block: add devs list to blkid command, add is_zfs_member

550. By Ryan Harper

fix indentation for zfs fstab entries

549. By Ryan Harper

Switch clear_holders to use load_kernel_module

548. By Ryan Harper

util add kernel module loading helpers

547. By Ryan Harper

dependencies: add kernel module depedency checks

546. By Ryan Harper

zfsutils only on xenial and newer

545. By Ryan Harper

drop ramsize change, not needed

544. By Ryan Harper

Update storage doc with zpool, zfs commands and ZFS Root example

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches