libzeitgeist

Merge lp://qastaging/~rainct/libzeitgeist/986099 into lp://qastaging/libzeitgeist

986099
Merge into trunk

Proposed by Siegfried Gevatter on 2012-04-23

Status:

Needs review

Proposed branch:

lp://qastaging/~rainct/libzeitgeist/986099

Merge into:

lp://qastaging/libzeitgeist

Diff against target:

240 lines (+136/-5)

8 files modified

.bzrignore (+1/-0)
bindings/zeitgeist-1.0.gi (+5/-1)
bindings/zeitgeist-1.0.vapi (+6/-1)
examples/Makefile.am (+4/-1)
examples/find-related.c (+104/-0)
src/zeitgeist-enums.h (+14/-0)
src/zeitgeist-log.c (+1/-1)
src/zeitgeist-log.h (+1/-1)

To merge this branch:

bzr merge lp://qastaging/~rainct/libzeitgeist/986099

Medium

Confirmed

Link a bug report

Reviewer	Review Type	Date Requested	Status
LibZeitgeist Developers		2012-04-23	Pending
Review via email: mp+103150@code.qastaging.launchpad.net

lp://qastaging/~rainct/libzeitgeist/986099 updated on 2012-04-23

238. By Siegfried Gevatter on 2012-04-23: Update Vala bindings.

Revision history for this message

Michal Hruby (mhr3) wrote on 2012-04-23:

Looks good to me, although it's a hidden API not-really-break. Not sure if this should go in the 0.3 series.

Revision history for this message

Mikkel Kamstrup Erlandsen (kamstrup) wrote on 2012-04-24:

Heh, good question... Do we know if this API has any consumers? The latest yelp additions maybe?

Revision history for this message

Mikkel Kamstrup Erlandsen (kamstrup) wrote on 2012-04-24:

For the record, I'll +1 this if we a reasonably sure we arent' gonna break some clients. (FWIW - the ABI remains the same... so we shouldn't break installed apps, some may need patching to compile again though)

Unmerged revisions

238. By Siegfried Gevatter on 2012-04-23: Update Vala bindings.
237. By Siegfried Gevatter on 2012-04-23: Fix find_related_uris result type (add missing RelevantResultType)