Merge lp://qastaging/~rainct/libzeitgeist/event-origin-subject-current-uri into lp://qastaging/libzeitgeist
Proposed by
Siegfried Gevatter
| Status: | Merged |
|---|---|
| Approved by: | Mikkel Kamstrup Erlandsen |
| Approved revision: | 216 |
| Merged at revision: | 216 |
| Proposed branch: | lp://qastaging/~rainct/libzeitgeist/event-origin-subject-current-uri |
| Merge into: | lp://qastaging/libzeitgeist |
| Diff against target: |
462 lines (+206/-15) 5 files modified
src/zeitgeist-event.c (+62/-3) src/zeitgeist-event.h (+4/-0) src/zeitgeist-subject.c (+34/-2) src/zeitgeist-subject.h (+4/-0) tests/test-event.c (+102/-10) |
| To merge this branch: | bzr merge lp://qastaging/~rainct/libzeitgeist/event-origin-subject-current-uri |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Mikkel Kamstrup Erlandsen | Approve | ||
|
Review via email:
|
|||
To post a comment you must log in.
Revision history for this message
| Siegfried Gevatter (rainct) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looking good Siegfried, and I am glad we that we can stick this in the ABI stable series. from the principle that any mrq with more than 100 lines must have at least one comment - here goes ;-) :
28 + * This differs from a subject's origin, as it describes where the event comes
29 + * from, not where it resides.
Can you add this event.set_origin() as well?