Merge lp://qastaging/~ralsina/account-polld/i18n into lp://qastaging/~ubuntu-push-hackers/account-polld/trunk

2 minor issues noted:

- missing debian/copyright for gettext/*
- gofmt or goimports has not been run agains this (spaces instead of tabs).

A couple of notes:

locale/account-polld.pot

- Traditionally the folder containing translations is named po/, not locale/. That said, there is nothing wrong with naming it locale, and it will work too. It's just a matter of consistency with other projects, so your call.

=== added directory 'locale/es_ES.utf8'
=== added file 'locale/es_ES.utf8/account-polld.po'

- This needs fixing though. Translations should be in a flat layout under the same folder as the .pot file, and they should be named using 2-letter ISO 639-1 codes, with some exceptions using 3-letter codes and others using the _CC suffix, where CC is the country code. That is, the file should be named locale/es.po
- In any case, I wouldn't add a .po file in this merge proposal and let Launchpad take care of it instead: we'll just enable automatic translation exports and all .po files will be committed with the right name and location.

sounds good, changing ASAP

On Tue, Jul 29, 2014 at 5:11 PM, David Planella <email address hidden>
wrote:

> Review: Needs Fixing
>
> A couple of notes:
>
> locale/account-polld.pot
>
> - Traditionally the folder containing translations is named po/, not
> locale/. That said, there is nothing wrong with naming it locale, and it
> will work too. It's just a matter of consistency with other projects, so
> your call.
>
> === added directory 'locale/es_ES.utf8'
> === added file 'locale/es_ES.utf8/account-polld.po'
>
> - This needs fixing though. Translations should be in a flat layout under
> the same folder as the .pot file, and they should be named using 2-letter
> ISO 639-1 codes, with some exceptions using 3-letter codes and others using
> the _CC suffix, where CC is the country code. That is, the file should be
> named locale/es.po
> - In any case, I wouldn't add a .po file in this merge proposal and let
> Launchpad take care of it instead: we'll just enable automatic translation
> exports and all .po files will be committed with the right name and
> location.
>
>
> --
> https://code.launchpad.net/~ralsina/account-polld/i18n/+merge/228747
> You are the owner of lp:~ralsina/account-polld/i18n.
>

As with the rest of our upstream projects, I'd recommend enabling automatic translation imports and exports. I set up as much as I could in Launchpad, but I'll need someone with permissions in the project to enable automatic commits.

That is:

1. Go to:
https://translations.launchpad.net/account-polld/trunk/+translations-settings
2: On "Export translations to branch", click on "Choose a target branch" and set it to ~ubuntu-push-hackers/account-polld/trunk

For more background: https://wiki.ubuntu.com/Translations/LpProjectConfiguration (the only step missing is the one described above)

In terms of building and installing the translations, there are generally preset rules in the build system, but I can't quite figure out if the project is using one at all.

In any case, I'm assuming this is installed as a .deb package.

There are 2 things that need doing:

1. Build the binary .mo files from the source .po files. This is done with msgfmt.
2. Install the .mo files at /usr/share/locale/$LANG/LC_MESSAGES/account-polld.mo, where $LANG is the language code (the same as the name of the source .po file - i.e. in es.po, $LANG would be 'es'). There is existing Debian packaging infrastructure to do this that works with language packs -> dh_translations

David, ack. Looks like I don't have the permission in launchpad either,
I'll bring it up tomorrow and then do the rest of the things you mentioned.

On Tue, Jul 29, 2014 at 5:27 PM, David Planella <email address hidden>
wrote:

> In terms of building and installing the translations, there are generally
> preset rules in the build system, but I can't quite figure out if the
> project is using one at all.
>
> In any case, I'm assuming this is installed as a .deb package.
>
> There are 2 things that need doing:
>
> 1. Build the binary .mo files from the source .po files. This is done with
> msgfmt.
> 2. Install the .mo files at
> /usr/share/locale/$LANG/LC_MESSAGES/account-polld.mo, where $LANG is the
> language code (the same as the name of the source .po file - i.e. in es.po,
> $LANG would be 'es'). There is existing Debian packaging infrastructure to
> do this that works with language packs -> dh_translations
> --
> https://code.launchpad.net/~ralsina/account-polld/i18n/+merge/228747
> You are the owner of lp:~ralsina/account-polld/i18n.
>