ubuntu-system-settings

Merge lp://qastaging/~ralsina/ubuntu-system-settings/per-package-notifications-rtm into lp://qastaging/ubuntu-system-settings/rtm-14.09

  1. per-package-notifications-rtm
  2. Merge into rtm-14.09
Proposed by Roberto Alsina
Status: Merged
Approved by: Ken VanDine
Approved revision: 1007
Merged at revision: 1010
Proposed branch: lp://qastaging/~ralsina/ubuntu-system-settings/per-package-notifications-rtm
Merge into: lp://qastaging/ubuntu-system-settings/rtm-14.09
Diff against target: 248 lines (+146/-37)
3 files modified
plugins/notifications/notification_manager.cpp (+88/-37)
plugins/notifications/notification_manager.h (+1/-0)
tests/autopilot/ubuntu_system_settings/tests/test_notifications.py (+57/-0)
To merge this branch: bzr merge lp://qastaging/~ralsina/ubuntu-system-settings/per-package-notifications-rtm
Reviewer Review Type Date Requested Status
Ken VanDine Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+254625@code.qastaging.launchpad.net

Commit message

Use per-package notification settings instead of per-app and per-scope.

Description of the change

------------

To test:

* Using the current ubuntu-system-settings, with telegram installed, you have 2 telegram entries on the notifications panel

* Using this version you should have one.

* If you untick the telegram item, and run this command, you should see something like this:

$ gsettings get com.ubuntu.notifications.hub blacklist

[('com.ubuntu.telegram', 'sctelegram'), ('com.ubuntu.telegram', 'telegram')]

* Ticking the telegram item should make those two items disappear

-------------

Additionally, if either one of the telegram items were NOT ticked, then the single telegram item in the new version should be NOT ticked.

If any other app was ticked/not ticked with the current version, it should stay the same in the new version.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1007
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-rtm-14.09-ci/74/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-14.09-touch/53
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-rtm-14.09-14.09-armhf-ci/75
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-rtm-14.09-14.09-armhf-ci/75/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-14.09-mako/54
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-14.09-armhf/53
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-14.09-armhf/53/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/19278

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-rtm-14.09-ci/74/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Ken VanDine (ken-vandine) wrote :

Looks good

review: Approve
lp://qastaging/~ralsina/ubuntu-system-settings/per-package-notifications-rtm updated
1008. By Roberto Alsina

new autopilot test for notifications plugin

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches