Merge lp://qastaging/~raof/do-plugins/merge into lp://qastaging/do-plugins

Proposed by Chris Halse Rogers
Status: Merged
Merged at revision: not available
Proposed branch: lp://qastaging/~raof/do-plugins/merge
Merge into: lp://qastaging/do-plugins
Diff against target: None lines
To merge this branch: bzr merge lp://qastaging/~raof/do-plugins/merge
Reviewer Review Type Date Requested Status
Do Plugins Team Pending
Review via email: mp+7920@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
Chris Halse Rogers (raof) wrote :

Fix the Flickr plugin build with gmcs 2.4.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Flickr/src/UploadAction.cs'
2--- Flickr/src/UploadAction.cs 2009-06-22 04:05:16 +0000
3+++ Flickr/src/UploadAction.cs 2009-06-26 01:51:40 +0000
4@@ -109,11 +109,20 @@
5 }
6
7 Services.Application.RunOnThread ( () => {
8- using (UploadPool uploadQueue = new UploadPool (tags)) {
9+ /* Mono 2.4 bug hack
10+ * This can't use using () due to some crazy-wierd scoping problem.
11+ * See https://bugzilla.novell.com/show_bug.cgi?id=516676 for details.
12+ *
13+ */
14+ IEnumerable<IFileItem> temp = uploads;
15+ UploadPool uploadQueue = new UploadPool (tags);
16+ try {
17 foreach (IFileItem photo in uploads)
18 uploadQueue.EnqueueUpload (photo);
19-
20+
21 uploadQueue.BeginUploads ();
22+ } finally {
23+ uploadQueue.Dispose ();
24 }
25 });
26
27

Subscribers

People subscribed via source and target branches