Mir

Merge lp://qastaging/~raof/mir/fix-1587569 into lp://qastaging/mir

  1. fix-1587569
  2. Merge into development-branch
Proposed by Chris Halse Rogers
Status: Work in progress
Proposed branch: lp://qastaging/~raof/mir/fix-1587569
Merge into: lp://qastaging/mir
Diff against target: 177 lines (+44/-19)
7 files modified
debian/mirtest-dev.install (+1/-1)
tests/CMakeLists.txt (+5/-2)
tests/mir_test/CMakeLists.txt (+0/-4)
tests/mir_test_doubles/CMakeLists.txt (+4/-4)
tests/mir_test_doubles/mock_udev.cpp (+32/-3)
tests/mir_test_framework/CMakeLists.txt (+0/-5)
tests/unit-tests/CMakeLists.txt (+2/-0)
To merge this branch: bzr merge lp://qastaging/~raof/mir/fix-1587569
Reviewer Review Type Date Requested Status
Mir CI Bot continuous-integration Needs Fixing
Mir development team Pending
Review via email: mp+296163@code.qastaging.launchpad.net

Commit message

Make mir-test-assist into a shared library.

Since we're shipping this for downstream users we might as well make it a shared library. This has a number of advantages:
*) We know that all symbols can be resolved by code we ship (this was not true), and
*) We can build it however we want without breaking downstreams.

Fixes: https://bugs.launchpad.net/mir/+bug/1587569

Description of the change

Ship mir-test-assist as a shared library, decoupling our compile options from downstream's.

To post a comment you must log in.
Revision history for this message
Mir CI Bot (mir-ci-bot) wrote :

FAILED: Continuous integration, rev:3526
https://mir-jenkins.ubuntu.com/job/mir-ci/1061/
Executed test runs:
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-mir/1169/console
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/1217
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/1208
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/1208
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=vivid+overlay/1179/console
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial/1179/console
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/1179
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/1179/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/1179
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/1179/artifact/output/*zip*/output.zip
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial/1179/console

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/1061/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

What the?... Is it just this branch?

05:21:23 11: [ FAILED ] 10 tests, listed below:
05:21:23 11: [ FAILED ] ClientLibraryThread.handles_no_signals
05:21:23 11: [ FAILED ] ClientLibraryThread.does_not_interfere_with_client_signal_handling
05:21:24 11: [ FAILED ] ServerShutdown.normal_exit_removes_endpoint
05:21:24 11: [ FAILED ] ClientCredsTestFixture.session_authorizer_receives_pid_of_connecting_clients
05:21:24 11: [ FAILED ] ClientCredsTestFixture.authorizer_may_prevent_connection_of_clients
05:21:24 11: [ FAILED ] ServerDisconnect.is_detected_by_client
05:21:24 11: [ FAILED ] ServerDisconnect.doesnt_stop_client_calling_API_functions
05:21:24 11: [ FAILED ] ServerStartup.creates_endpoint_on_filesystem
05:21:24 11: [ FAILED ] ServerStartup.after_server_sigkilled_can_start_new_instance
05:21:24 11: [ FAILED ] UnresponsiveClient.does_not_hang_server

Reply
Revision history for this message
Chris Halse Rogers (raof) wrote :

The ClientCookies test appears to be leaking state, resulting in the
above valgrind errors; I'm investigating.

Reply
Revision history for this message
Chris Halse Rogers (raof) wrote :

Ah, OK. The problem here appears to be that ~StubInputPlatform() is duplicated; in the stub platform module and also built directly into the acceptance-tests.

Leaving it only in the input module fixes the failures, but breaks the InputPlatformProbing tests which need the typeinfo for StubInputPlatform for $REASONS.

I'll fix this tomorrow.

Reply
lp://qastaging/~raof/mir/fix-1587569 updated
3527. By Chris Halse Rogers

Don't include stub_input_platform.cpp twice.

Revision history for this message
Mir CI Bot (mir-ci-bot) wrote :

FAILED: Continuous integration, rev:3527
https://mir-jenkins.ubuntu.com/job/mir-ci/1068/
Executed test runs:
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-mir/1177/console
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/1227
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/1218
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/1218
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=vivid+overlay/1187/console
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial/1187
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial/1187/artifact/output/*zip*/output.zip
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/1187/console
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/1187/artifact/output/*zip*/output.zip
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/1187/console
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial/1187
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial/1187/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/1068/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Chris Halse Rogers (raof) wrote :

SET IT ALL ON FIRE

Reply

Unmerged revisions

3527. By Chris Halse Rogers

Don't include stub_input_platform.cpp twice.

3526. By Chris Halse Rogers

Don't special-case LTO for test framework.

It would be sensible for us to only enable LTO for our main libraries, but stripping it off
ad-hoc is not the best way to do that ☺

3525. By Chris Halse Rogers

Make mir-test-assist into a shared library.

Since we're shipping this for downstream users we might as well make it a shared library. This
has a number of advantages:
*) We know that all symbols can be resolved by code we ship (this was not true), and
*) We can build it however we want without breaking downstreams.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches