Mir

Merge lp://qastaging/~raof/mir/remove-eventloop-self-immolation into lp://qastaging/mir

  1. remove-eventloop-self-immolation
  2. Merge into development-branch
Proposed by Chris Halse Rogers
Status: Merged
Approved by: Alan Griffiths
Approved revision: no longer in the source branch.
Merged at revision: 2474
Proposed branch: lp://qastaging/~raof/mir/remove-eventloop-self-immolation
Merge into: lp://qastaging/mir
Diff against target: 96 lines (+29/-28)
2 files modified
src/common/dispatch/simple_dispatch_thread.cpp (+8/-2)
tests/unit-tests/dispatch/test_simple_dispatch_thread.cpp (+21/-26)
To merge this branch: bzr merge lp://qastaging/~raof/mir/remove-eventloop-self-immolation
Reviewer Review Type Date Requested Status
Alan Griffiths Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+255767@code.qastaging.launchpad.net

Commit message

Abort with an error message if attempting to destroy SimpleDispatchThread from a dispatch() callback.

This replaces the previous behaviour of detaching the thread and continuing, which caused problems in the tests.
Fixes: https://bugs.launchpad.net/mir/+bug/1441620

Description of the change

Abort with an error message if attempting to destroy SimpleDispatchThread from a dispatch() callback.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:2475
http://jenkins.qa.ubuntu.com/job/mir-ci/3489/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/2011
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/2010
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/1961
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-vivid-amd64-ci/1486
        deb: http://jenkins.qa.ubuntu.com/job/mir-vivid-amd64-ci/1486/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/1961
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/1961/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-mako/4897
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/19528

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/3489/rebuild

review: Approve (continuous-integration)
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches