Mir

Merge lp://qastaging/~raof/mir/sigPIIIIIIIPE into lp://qastaging/mir

sigPIIIIIIIPE
Merge into development-branch

Proposed by Chris Halse Rogers on 2014-09-02

Status:	Work in progress
Proposed branch:	lp://qastaging/~raof/mir/sigPIIIIIIIPE
Merge into:	lp://qastaging/mir
Prerequisite:	lp://qastaging/~raof/mir/dont-kill-the-poor-clients
Diff against target:	105 lines (+3/-9) 8 files modified examples/eglapp.c (+0/-1) examples/fingerpaint.c (+0/-1) examples/multiwin.c (+0/-1) examples/progressbar.c (+0/-1) src/client/mir_connection.cpp (+1/-1) src/utils/ping.c (+0/-1) src/utils/screencast.cpp (+0/-1) tests/acceptance-tests/test_server_disconnect.cpp (+2/-2)
To merge this branch:	bzr merge lp://qastaging/~raof/mir/sigPIIIIIIIPE
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot (community)	continuous-integration		Needs Fixing on 2014-09-12
Daniel van Vugt			Needs Fixing on 2014-09-04
Cemil Azizoglu (community)			Approve on 2014-09-03
Kevin DuBois (community)			Approve on 2014-09-02
Alexandros Frantzis (community)		2014-09-02	Approve on 2014-09-02
Review via email: mp+232994@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2014-09-02.

Commit message

Use SIGPIPE rather than SIGHUP for the disconnect signal.

No one should be catching either, but SIGPIPE is what's used by everyone else in this situation.

Description of the change

Use SIGPIPE rather than SIGHUP for the disconnect signal.

No one should be catching either, but SIGPIPE is what's used by everyone else in this situation.

Revision history for this message

Alexandros Frantzis (afrantzis) wrote on 2014-09-02:

I prefer SIGPIPE too, but I remember Daniel had some issues when testing with it. Let's see how it goes this time.

review: Approve

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-09-02:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-team-mir-development-branch-ci/2569/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-09-02:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-team-mir-development-branch-ci/2575/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Kevin DuBois (kdub) wrote on 2014-09-02:

seems like good enough reasons to sway me to preferring one over the other. (https://code.launchpad.net/~vanvugt/mir/hangup/+merge/231696/comments/564707)
lgtm

review: Approve

Revision history for this message

Cemil Azizoglu (cemil-azizoglu) wrote on 2014-09-02:

Looks good, but there are still instances of examples and utils using SIGHUP.

review: Needs Fixing

lp://qastaging/~raof/mir/sigPIIIIIIIPE updated on 2014-09-03

1889. By Chris Halse Rogers on 2014-09-03: Remove remnant SIGHUP handling

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-09-03:

FAILED: Continuous integration, rev:1889
http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-ci/2586/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-utopic-i386-build/1571
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-clang-utopic-amd64-build/1577/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-utopic-touch/1553/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-utopic-amd64-ci/1108/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-utopic-armhf/490/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-team-mir-development-branch-ci/2586/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-09-03:

FAILED: Continuous integration, rev:1889
http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-ci/2589/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-utopic-i386-build/1574
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-clang-utopic-amd64-build/1580/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-utopic-touch/1556/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-utopic-amd64-ci/1111/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-utopic-armhf/493/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-team-mir-development-branch-ci/2589/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Cemil Azizoglu (cemil-azizoglu) wrote on 2014-09-03:

LGTM.

review: Approve

Revision history for this message

Daniel van Vugt (vanvugt) wrote on 2014-09-04:

After the pending SIGKILL fix lands, you will have a conflict that needs fixing here. Also the prereq branch still needs fixing (introduces a regression).

review: Needs Fixing

lp://qastaging/~raof/mir/sigPIIIIIIIPE updated on 2014-09-05

1890. By Chris Halse Rogers on 2014-09-05: Merged dont-signal-on-explicit-release into use-sigpipe.
1891. By Chris Halse Rogers on 2014-09-05: Fix (harmless) mis-merge
1892. By Chris Halse Rogers on 2014-09-05: Merge prereq
1893. By Chris Halse Rogers on 2014-09-05: Merged dont-signal-on-explicit-release into use-sigpipe.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-09-05:

FAILED: Continuous integration, rev:1891
http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-ci/2621/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-android-utopic-i386-build/1617/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-clang-utopic-amd64-build/1623/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-utopic-touch/1599/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-utopic-amd64-ci/1143/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-utopic-armhf/536/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-team-mir-development-branch-ci/2621/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-09-05:

FAILED: Continuous integration, rev:1893
http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-ci/2624/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-utopic-i386-build/1620
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-utopic-amd64-build/1626
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-utopic-touch/1602/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-utopic-amd64-ci/1146/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-utopic-armhf/539/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-team-mir-development-branch-ci/2624/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-09-05:

FAILED: Continuous integration, rev:1891
http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-ci/2629/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-utopic-i386-build/1625
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-utopic-amd64-build/1631
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-utopic-touch/1607/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-utopic-amd64-ci/1151/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-utopic-armhf/544/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-team-mir-development-branch-ci/2629/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~raof/mir/sigPIIIIIIIPE updated on 2014-09-08

1894. By Chris Halse Rogers on 2014-09-08: Merged dont-signal-on-explicit-release into use-sigpipe.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-09-08:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-team-mir-development-branch-ci/2648/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~raof/mir/sigPIIIIIIIPE updated on 2014-09-11

1895. By Chris Halse Rogers on 2014-09-11: Merged dont-signal-on-explicit-release into use-sigpipe.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-09-11:

FAILED: Continuous integration, rev:1895
http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-ci/2691/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-utopic-i386-build/1715
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-utopic-amd64-build/1722
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-utopic-touch/1694/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-utopic-amd64-ci/1213/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-utopic-armhf/631/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-team-mir-development-branch-ci/2691/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~raof/mir/sigPIIIIIIIPE updated on 2014-09-11

1896. By Chris Halse Rogers on 2014-09-11: Merged dont-signal-on-explicit-release into use-sigpipe.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-09-12:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-team-mir-development-branch-ci/2707/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~raof/mir/sigPIIIIIIIPE updated on 2014-09-12

1897. By Chris Halse Rogers on 2014-09-12: Merged dont-signal-on-explicit-release into use-sigpipe.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-09-12:

FAILED: Continuous integration, rev:1897
http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-ci/2715/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-utopic-i386-build/1747
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-clang-utopic-amd64-build/1754/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-utopic-touch/1726/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-utopic-amd64-ci/1237/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-utopic-armhf/663/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-team-mir-development-branch-ci/2715/rebuild

review: Needs Fixing (continuous-integration)

Unmerged revisions

1897. By Chris Halse Rogers on 2014-09-12

Merged dont-signal-on-explicit-release into use-sigpipe.

1896. By Chris Halse Rogers on 2014-09-11

Merged dont-signal-on-explicit-release into use-sigpipe.

1895. By Chris Halse Rogers on 2014-09-11

Merged dont-signal-on-explicit-release into use-sigpipe.

1894. By Chris Halse Rogers on 2014-09-08

Merged dont-signal-on-explicit-release into use-sigpipe.

1893. By Chris Halse Rogers on 2014-09-05

Merged dont-signal-on-explicit-release into use-sigpipe.

1892. By Chris Halse Rogers on 2014-09-05

Merge prereq

1891. By Chris Halse Rogers on 2014-09-05

Fix (harmless) mis-merge

1890. By Chris Halse Rogers on 2014-09-05

Merged dont-signal-on-explicit-release into use-sigpipe.

1889. By Chris Halse Rogers on 2014-09-03

Remove remnant SIGHUP handling

1888. By Chris Halse Rogers on 2014-09-02

Use SIGPIPE rather than SIGHUP for disconnect signal.

Signals are the worst possible API, so don't use them, people! Register a lifecycle callback
and wait for mir_lifecycle_connection_lost to detect server disconnects!

For clients that just don't care, use SIGPIPE. That's what libwayland and libX11 use.