Mir

Merge lp://qastaging/~raof/mir/threads-and-madness into lp://qastaging/~mir-team/mir/trunk

  1. threads-and-madness
  2. Merge into trunk
Proposed by Chris Halse Rogers
Status: Merged
Approved by: Robert Ancell
Approved revision: no longer in the source branch.
Merged at revision: 841
Proposed branch: lp://qastaging/~raof/mir/threads-and-madness
Merge into: lp://qastaging/~mir-team/mir/trunk
Diff against target: 144 lines (+112/-0)
2 files modified
src/client/rpc/mir_socket_rpc_channel.cpp (+23/-0)
tests/acceptance-tests/test_client_library.cpp (+89/-0)
To merge this branch: bzr merge lp://qastaging/~raof/mir/threads-and-madness
Reviewer Review Type Date Requested Status
Thomas Voß (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Robert Ancell Approve
Review via email: mp+174098@code.qastaging.launchpad.net

Commit message

Make libmirclient not aggressively signal-unsafe by blocking signals on our
IO thread.

Fixes infinite loop in XMir (LP: #1199319)

Description of the change

Make libmirclient not aggressively signal-unsafe by blocking signals on our
IO thread.

Fixes: (LP: #1199319)

To post a comment you must log in.
Revision history for this message
Robert Ancell (robert-ancell) wrote :

I don't understand the details but looks sane. Well, except for the commit comment that is...

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:835
http://jenkins.qa.ubuntu.com/job/mir-ci/977/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-saucy-i386-build/1263
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-saucy-amd64-build/1147
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-saucy-amd64-ci/215
        deb: http://jenkins.qa.ubuntu.com/job/mir-saucy-amd64-ci/215/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-vm-ci-build/./distribution=quantal,flavor=amd64/614

Click here to trigger a rebuild:
http://s-jenkins:8080/job/mir-ci/977/rebuild

review: Approve (continuous-integration)
Revision history for this message
Thomas Voß (thomas-voss) wrote :

LGTM, and in accordance with http://www.boost.org/doc/libs/1_45_0/doc/html/boost_asio/example/http/server4/posix_main.cpp

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches