Merge lp://qastaging/~raoul-snyman/openlp/bug-1742910 into lp://qastaging/openlp

Proposed by Raoul Snyman
Status: Merged
Merged at revision: 2808
Proposed branch: lp://qastaging/~raoul-snyman/openlp/bug-1742910
Merge into: lp://qastaging/openlp
Diff against target: 755 lines (+333/-194)
10 files modified
openlp/core/app.py (+1/-1)
openlp/core/common/path.py (+2/-2)
openlp/core/threading.py (+14/-10)
openlp/core/ui/mainwindow.py (+3/-4)
tests/functional/openlp_core/api/http/test_error.py (+37/-35)
tests/functional/openlp_core/api/test_deploy.py (+94/-15)
tests/functional/openlp_core/common/test_path.py (+14/-1)
tests/functional/openlp_core/lib/test_path.py (+0/-87)
tests/functional/openlp_core/lib/test_ui.py (+55/-28)
tests/functional/openlp_core/test_threading.py (+113/-11)
To merge this branch: bzr merge lp://qastaging/~raoul-snyman/openlp/bug-1742910
Reviewer Review Type Date Requested Status
Tim Bentley Approve
Review via email: mp+336066@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2018-01-13.

Description of the change

Fix bug #1742910 by moving the threads to the application object instead of the main window object.

Add this to your merge proposal:
--------------------------------------------------------------------------------
lp:~raoul-snyman/openlp/bug-1742910 (revision 2810)
https://ci.openlp.io/job/Branch-01-Pull/2418/ [SUCCESS]
https://ci.openlp.io/job/Branch-02a-Linux-Tests/2319/ [SUCCESS]
https://ci.openlp.io/job/Branch-02b-macOS-Tests/114/ [SUCCESS]
https://ci.openlp.io/job/Branch-03a-Build-Source/36/ [SUCCESS]
https://ci.openlp.io/job/Branch-03b-Build-macOS/35/ [SUCCESS]
https://ci.openlp.io/job/Branch-04a-Code-Analysis/1498/ [SUCCESS]
https://ci.openlp.io/job/Branch-04b-Test-Coverage/1311/ [SUCCESS]
https://ci.openlp.io/job/Branch-05-AppVeyor-Tests/262/ [FAILURE]
Stopping after failure

Failed builds:
 - Branch-05-AppVeyor-Tests #262: https://ci.openlp.io/job/Branch-05-AppVeyor-Tests/262/console

To post a comment you must log in.
Revision history for this message
Tim Bentley (trb143) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.