OpenLP

Merge lp://qastaging/~raoul-snyman/openlp/bundle-libvlc into lp://qastaging/openlp

  1. bundle-libvlc
  2. Merge into trunk
Proposed by Raoul Snyman
Status: Superseded
Proposed branch: lp://qastaging/~raoul-snyman/openlp/bundle-libvlc
Merge into: lp://qastaging/openlp
Diff against target: 94 lines (+22/-9)
3 files modified
openlp/core/app.py (+10/-1)
openlp/core/ui/mainwindow.py (+1/-1)
scripts/appveyor.yml (+11/-7)
To merge this branch: bzr merge lp://qastaging/~raoul-snyman/openlp/bundle-libvlc
Reviewer Review Type Date Requested Status
Tomas Groth Pending
Tim Bentley Pending
Review via email: mp+367870@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2019-05-22.

This proposal has been superseded by a proposal from 2019-05-23.

Commit message

Work in Progress

For now, this is a bit of a work-in-progress. This code should pick up the bundled libvlc.(dll|so|dylib) and use it. VLC detection seems to be a little iffy right now.

Description of the change

Work in Progress

For now, this is a bit of a work-in-progress. This code should pick up the bundled libvlc.(dll|so|dylib) and use it. VLC detection seems to be a little iffy right now.

Please review though :-)

To post a comment you must log in.
Revision history for this message
Raoul Snyman (raoul-snyman) wrote : Posted in a previous version of this proposal

Linux tests passed!

Revision history for this message
Raoul Snyman (raoul-snyman) wrote : Posted in a previous version of this proposal

Linting failed, please see https://ci.openlp.io/job/MP-03-Linting/100/ for more details

Revision history for this message
Raoul Snyman (raoul-snyman) wrote : Posted in a previous version of this proposal

Linux tests passed!

Revision history for this message
Raoul Snyman (raoul-snyman) wrote : Posted in a previous version of this proposal

Linting passed!

Revision history for this message
Raoul Snyman (raoul-snyman) wrote : Posted in a previous version of this proposal

macOS tests passed!

Revision history for this message
Tim Bentley (trb143) wrote : Posted in a previous version of this proposal

Looks good for the bits I understand!

review: Approve
Revision history for this message
Raoul Snyman (raoul-snyman) wrote : Posted in a previous version of this proposal

Linux tests passed!

Revision history for this message
Raoul Snyman (raoul-snyman) wrote : Posted in a previous version of this proposal

Linting passed!

Revision history for this message
Raoul Snyman (raoul-snyman) wrote : Posted in a previous version of this proposal

macOS tests passed!

Revision history for this message
Tomas Groth (tomasgroth) wrote : Posted in a previous version of this proposal

A few changes needed for appveyor script. See inline

review: Needs Fixing
lp://qastaging/~raoul-snyman/openlp/bundle-libvlc updated
2874. By Raoul Snyman

Re-enable the tests

Revision history for this message
Raoul Snyman (raoul-snyman) wrote :

Linux tests passed!

Revision history for this message
Raoul Snyman (raoul-snyman) wrote :

Linting passed!

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.